From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] mirror: Fix guest responsiveness during bitmap scan
Date: Fri, 10 Jul 2015 14:43:50 +0800 [thread overview]
Message-ID: <20150710064350.GG31230@ad.nay.redhat.com> (raw)
In-Reply-To: <20150709130208.GD11166@stefanha-thinkpad.redhat.com>
On Thu, 07/09 14:02, Stefan Hajnoczi wrote:
> This patch only converts the mirror block job to use the new relax
> function. The other block jobs (stream, backup, commit) are still using
> a 0 ns delay and are therefore broken. They should probably be
> converted in the same series.
That's because they all can be perfectly mitigated by setting a reasonable
"speed" that matchs the host horsepower. Thinking about this again, I doubt
that lengthening the duration with a hardcoded value benifits everyone; and
before Alexandre's reply on old server/slow disks, I don't recall any report,
because the coroutines would already yield often enough, when waiting for IO to
complete. So I am not sure whether they're broken in practice.
Fam
next prev parent reply other threads:[~2015-07-10 6:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 3:47 [Qemu-devel] [PATCH 0/3] mirror: Fix guest responsiveness during bitmap scan Fam Zheng
2015-07-09 3:47 ` [Qemu-devel] [PATCH 1/3] blockjob: Introduce block_job_relax_cpu Fam Zheng
2015-07-09 12:54 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-07-10 3:42 ` Alexandre DERUMIER
2015-07-14 12:31 ` Stefan Hajnoczi
2015-07-15 10:32 ` Fam Zheng
2015-07-16 13:21 ` Stefan Hajnoczi
2015-07-09 3:47 ` [Qemu-devel] [PATCH 2/3] mirror: Use block_job_relax_cpu during bitmap scanning Fam Zheng
2015-07-09 13:00 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-07-09 3:47 ` [Qemu-devel] [PATCH 3/3] mirror: Speed up bitmap initial scanning Fam Zheng
2015-07-09 13:00 ` Stefan Hajnoczi
2015-07-14 13:21 ` Stefan Hajnoczi
2015-07-09 11:51 ` [Qemu-devel] [PATCH 0/3] mirror: Fix guest responsiveness during bitmap scan Alexandre DERUMIER
2015-07-09 13:02 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-07-09 13:18 ` Alexandre DERUMIER
2015-07-10 6:43 ` Fam Zheng [this message]
2015-07-10 6:54 ` Alexandre DERUMIER
2015-07-10 7:13 ` Fam Zheng
2015-07-10 10:36 ` Alexandre DERUMIER
2015-07-10 12:16 ` Alexandre DERUMIER
2015-07-13 5:08 ` Fam Zheng
2015-07-14 12:40 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710064350.GG31230@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.