All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	linux-gpio@vger.kernel.org, Jiang Liu <jiang.liu@linux.intel.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Julia Lawall <Julia.Lawall@lip6.fr>
Subject: [patch 05/19] gpiolib: Consolidate chained IRQ handler install/remove
Date: Mon, 13 Jul 2015 20:41:22 -0000	[thread overview]
Message-ID: <20150712232405.127041870@linutronix.de> (raw)
In-Reply-To: 20150712232317.244138485@linutronix.de

[-- Attachment #1: gpiolib-Consolidate-chained-IRQ-handler-install-remo.patch --]
[-- Type: text/plain, Size: 1147 bytes --]

Chained irq handlers usually set up handler data as well. We now have
a function to set both under irq_desc->lock. Replace the two calls
with one.

Search and conversion was done with coccinelle:

Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
---
 drivers/gpio/gpiolib.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: tip/drivers/gpio/gpiolib.c
===================================================================
--- tip.orig/drivers/gpio/gpiolib.c
+++ tip/drivers/gpio/gpiolib.c
@@ -443,8 +443,8 @@ void gpiochip_set_chained_irqchip(struct
 		 * The parent irqchip is already using the chip_data for this
 		 * irqchip, so our callbacks simply use the handler_data.
 		 */
-		irq_set_handler_data(parent_irq, gpiochip);
-		irq_set_chained_handler(parent_irq, parent_handler);
+		irq_set_chained_handler_and_data(parent_irq, parent_handler,
+						 gpiochip);
 
 		gpiochip->irq_parent = parent_irq;
 	}



  parent reply	other threads:[~2015-07-13 20:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 20:41 [patch 00/19] gpio: Interrupt cleanups and API change preparation Thomas Gleixner
2015-07-13 20:41 ` [patch 01/19] gpio/mpc8xxx: Consolidate chained IRQ handler install/remove Thomas Gleixner
2015-07-13 20:41 ` [patch 02/19] gpio/mvebu: " Thomas Gleixner
2015-07-13 20:41 ` [patch 03/19] gpio/timberdale: " Thomas Gleixner
2015-07-13 20:41 ` [patch 04/19] gpio/tz1090: " Thomas Gleixner
2015-07-13 20:41 ` Thomas Gleixner [this message]
2015-07-13 20:41 ` [patch 06/19] gpio/zynq: Use irq_set_chip_handler_name_locked() Thomas Gleixner
2015-07-13 20:41 ` [patch 07/19] gpio/ep93xx: Use irq_set_handler_locked() Thomas Gleixner
2015-07-13 20:41 ` [patch 08/19] gpio/msm-v2: " Thomas Gleixner
2015-07-13 20:41 ` [patch 09/19] gpio/omap: " Thomas Gleixner
2015-07-13 20:41 ` [patch 10/19] gpio/pch: " Thomas Gleixner
2015-07-13 20:41 ` [patch 11/19] gpio/gpio-tegra: " Thomas Gleixner
2015-07-13 20:41 ` [patch 12/19] gpio/davinci: Use accessor function irq_data_get_irq_handler_data() Thomas Gleixner
2015-07-13 20:41 ` [patch 13/19] gpio: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Thomas Gleixner
2015-07-13 20:41 ` [patch 14/19] gpio/davinci: Prepare gpio_irq_handler for irq argument removal Thomas Gleixner
2015-07-13 20:41 ` [patch 15/19] gpio/ep93xx: Prepare ep93xx_gpio_f_irq_handler " Thomas Gleixner
2015-07-13 20:41 ` [patch 16/19] gpio/mvebu: Prepare mvebu_gpio_irq_handler " Thomas Gleixner
2015-07-13 20:41 ` [patch 17/19] gpio/sa1100: Prepare sa1100_gpio_handler " Thomas Gleixner
2015-07-13 20:41 ` [patch 18/19] gpio/msm-v2: Avoid redundant lookup of irq_data Thomas Gleixner
     [not found]   ` <CAKb7UviaGO2a=B7_4CbirQU=JLS5D_bNAe-PWzL-8Sp621rkYQ@mail.gmail.com>
2015-07-14  5:39     ` Jiang Liu
2015-07-14 10:14     ` Thomas Gleixner
2015-07-13 20:41 ` [patch 19/19] gpio/davinci: " Thomas Gleixner
2015-07-14 10:16   ` Thomas Gleixner
2015-07-16 13:55 ` [patch 00/19] gpio: Interrupt cleanups and API change preparation Linus Walleij
2015-07-16 14:13   ` Thomas Gleixner
2015-07-17 12:47     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150712232405.127041870@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=gnurou@gmail.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.