From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave.Martin@arm.com (Dave Martin) Date: Mon, 13 Jul 2015 15:44:34 +0100 Subject: [PATCH v2 08/10] arm64/debug: Add missing #include In-Reply-To: <20150713143436.GG19083@leverpostej> References: <1436793967-7138-1-git-send-email-Dave.Martin@arm.com> <1436793967-7138-9-git-send-email-Dave.Martin@arm.com> <20150713143436.GG19083@leverpostej> Message-ID: <20150713144433.GB10670@e103592.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jul 13, 2015 at 03:34:36PM +0100, Mark Rutland wrote: > On Mon, Jul 13, 2015 at 02:25:55PM +0100, Dave P Martin wrote: > > relies on , but doesn't > > declare this dependency. This becomes a problem once > > debug-monitors.h starts getting included all over the place to get > > the BRK immedates. > > I take it that's for struct pt_regs down in the ifndef __ASSEMBLY__ > portion? Yes ... I suppose I could move the #include in there, but it seems hermless. I prefer to keep them together. > > > > > This patch adds the missing #include. > > > > Signed-off-by: Dave Martin > > --- > > arch/arm64/include/asm/debug-monitors.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/include/asm/debug-monitors.h b/arch/arm64/include/asm/debug-monitors.h > > index 6a17fb8..b5715cb 100644 > > --- a/arch/arm64/include/asm/debug-monitors.h > > +++ b/arch/arm64/include/asm/debug-monitors.h > > @@ -20,6 +20,7 @@ > > > > #include > > #include > > +#include > > We're also missing (for struct list_head, u8, and u32), > and (for ENODEV in the reinstall_suspended_bps stub). > Would you be able to fold those in? Sure, can do. > With those: > > Acked-by: Mark Rutland Cheers ---Dave > > Mark. > > > > > /* Low-level stepping controls. */ > > #define DBG_MDSCR_SS (1 << 0) > > -- > > 1.7.10.4 > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel