From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831AbbGMPo7 (ORCPT ); Mon, 13 Jul 2015 11:44:59 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50274 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751658AbbGMPo5 (ORCPT ); Mon, 13 Jul 2015 11:44:57 -0400 Date: Mon, 13 Jul 2015 16:42:55 +0100 From: Mark Brown To: Tomeu Vizoso Cc: "devicetree@vger.kernel.org" , linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, linux-gpio@vger.kernel.org, Takashi Iwai , Liam Girdwood , Stephen Warren , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , linux-acpi@vger.kernel.org, Thierry Reding , Linux PWM List , "linux-tegra@vger.kernel.org" , Alexandre Courbot Message-ID: <20150713154254.GH11162@sirena.org.uk> References: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> <1435743667-11987-12-git-send-email-tomeu.vizoso@collabora.com> <20150701173802.GW11162@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xZKIQynyWHxCFrdv" Content-Disposition: inline In-Reply-To: X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xZKIQynyWHxCFrdv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote: > On 1 July 2015 at 19:38, Mark Brown wrote: > > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: > >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, > >> + struct list_head *deps) > >> +{ > >> + add_dependency(fwnode, "nvidia,i2s-controller", deps); > >> + add_dependency(fwnode, "nvidia,audio-codec", deps); > >> +} > > Why is this all being open coded in an individual driver (we already > > know about and manage all these dependencies in the core...)? If we're > > going to do this I'd expect the interface for specifying DT nodes to the > > core to be changed to support this. > Are you thinking of changing drivers to acquire their resources > through Arnd's devm_probe (only that the resource table would have to > be in struct device_driver)? > https://lkml.kernel.org/g/4742258.TBitC3hVuO@wuerfel No, I'm looking at how we already have all the "did all my dependencies appear" logic in the core based on data provided by the drivers. --xZKIQynyWHxCFrdv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVo9x+AAoJECTWi3JdVIfQCtwH/iR0OWw9MmX0rTpPvdi+DKPm GHa0Sy8ieGKrBj60HzGLfLWerctXgSsB/dFWytfnpg4ebqe3Yc4TIcvADmbcA84L 4nq+I73X1bB9XrAd6+DEAAZ3pWdInbgw+P+VBdZJAmFHaY7pg7SeQmZr4xs3vaPh 6awa7eHWto27IT7zrOLHy12bBcFwmWZTQ/qh4XMWUPMc30/mfUoGBFzw+YokJGnw sFv3JkWM7bXEDdv2y1Vd39730mDC3K8dCMadzDBIcgfECKUR2/Gmh0vxttkhyy6d jTa4et1Urk1BsEoVSTT70QFvrvMveGGfFO7tXOD9qWE96pV7B6yIYEhjEne0Eg4= =Q8CS -----END PGP SIGNATURE----- --xZKIQynyWHxCFrdv-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes Date: Mon, 13 Jul 2015 16:42:55 +0100 Message-ID: <20150713154254.GH11162@sirena.org.uk> References: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> <1435743667-11987-12-git-send-email-tomeu.vizoso@collabora.com> <20150701173802.GW11162@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xZKIQynyWHxCFrdv" Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tomeu Vizoso Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Takashi Iwai , Liam Girdwood , Stephen Warren , "Rafael J. Wysocki" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thierry Reding , Linux PWM List , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Alexandre Courbot List-Id: linux-acpi@vger.kernel.org --xZKIQynyWHxCFrdv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote: > On 1 July 2015 at 19:38, Mark Brown wrote: > > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: > >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, > >> + struct list_head *deps) > >> +{ > >> + add_dependency(fwnode, "nvidia,i2s-controller", deps); > >> + add_dependency(fwnode, "nvidia,audio-codec", deps); > >> +} > > Why is this all being open coded in an individual driver (we already > > know about and manage all these dependencies in the core...)? If we're > > going to do this I'd expect the interface for specifying DT nodes to the > > core to be changed to support this. > Are you thinking of changing drivers to acquire their resources > through Arnd's devm_probe (only that the resource table would have to > be in struct device_driver)? > https://lkml.kernel.org/g/4742258.TBitC3hVuO@wuerfel No, I'm looking at how we already have all the "did all my dependencies appear" logic in the core based on data provided by the drivers. --xZKIQynyWHxCFrdv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVo9x+AAoJECTWi3JdVIfQCtwH/iR0OWw9MmX0rTpPvdi+DKPm GHa0Sy8ieGKrBj60HzGLfLWerctXgSsB/dFWytfnpg4ebqe3Yc4TIcvADmbcA84L 4nq+I73X1bB9XrAd6+DEAAZ3pWdInbgw+P+VBdZJAmFHaY7pg7SeQmZr4xs3vaPh 6awa7eHWto27IT7zrOLHy12bBcFwmWZTQ/qh4XMWUPMc30/mfUoGBFzw+YokJGnw sFv3JkWM7bXEDdv2y1Vd39730mDC3K8dCMadzDBIcgfECKUR2/Gmh0vxttkhyy6d jTa4et1Urk1BsEoVSTT70QFvrvMveGGfFO7tXOD9qWE96pV7B6yIYEhjEne0Eg4= =Q8CS -----END PGP SIGNATURE----- --xZKIQynyWHxCFrdv-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 13 Jul 2015 15:42:55 +0000 Subject: Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes Message-Id: <20150713154254.GH11162@sirena.org.uk> MIME-Version: 1 Content-Type: multipart/mixed; boundary="xZKIQynyWHxCFrdv" List-Id: References: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> <1435743667-11987-12-git-send-email-tomeu.vizoso@collabora.com> <20150701173802.GW11162@sirena.org.uk> In-Reply-To: To: Tomeu Vizoso Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Takashi Iwai , Liam Girdwood , Stephen Warren , "Rafael J. Wysocki" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thierry Reding , Linux PWM List , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Alexandre Courbot --xZKIQynyWHxCFrdv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote: > On 1 July 2015 at 19:38, Mark Brown wrote: > > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: > >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, > >> + struct list_head *deps) > >> +{ > >> + add_dependency(fwnode, "nvidia,i2s-controller", deps); > >> + add_dependency(fwnode, "nvidia,audio-codec", deps); > >> +} > > Why is this all being open coded in an individual driver (we already > > know about and manage all these dependencies in the core...)? If we're > > going to do this I'd expect the interface for specifying DT nodes to the > > core to be changed to support this. > Are you thinking of changing drivers to acquire their resources > through Arnd's devm_probe (only that the resource table would have to > be in struct device_driver)? > https://lkml.kernel.org/g/4742258.TBitC3hVuO@wuerfel No, I'm looking at how we already have all the "did all my dependencies appear" logic in the core based on data provided by the drivers. --xZKIQynyWHxCFrdv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVo9x+AAoJECTWi3JdVIfQCtwH/iR0OWw9MmX0rTpPvdi+DKPm GHa0Sy8ieGKrBj60HzGLfLWerctXgSsB/dFWytfnpg4ebqe3Yc4TIcvADmbcA84L 4nq+I73X1bB9XrAd6+DEAAZ3pWdInbgw+P+VBdZJAmFHaY7pg7SeQmZr4xs3vaPh 6awa7eHWto27IT7zrOLHy12bBcFwmWZTQ/qh4XMWUPMc30/mfUoGBFzw+YokJGnw sFv3JkWM7bXEDdv2y1Vd39730mDC3K8dCMadzDBIcgfECKUR2/Gmh0vxttkhyy6d jTa4et1Urk1BsEoVSTT70QFvrvMveGGfFO7tXOD9qWE96pV7B6yIYEhjEne0Eg4= =Q8CS -----END PGP SIGNATURE----- --xZKIQynyWHxCFrdv--