From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbbGNDEM (ORCPT ); Mon, 13 Jul 2015 23:04:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40978 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbbGNDEL (ORCPT ); Mon, 13 Jul 2015 23:04:11 -0400 Date: Mon, 13 Jul 2015 20:04:10 -0700 From: Greg Kroah-Hartman To: Oleg Drokin Cc: devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Dan Carpenter Subject: Re: [PATCH 18/20] staging/lustre/libcfs: get rid of debugfs/lnet/debug_mb Message-ID: <20150714030410.GA31396@kroah.com> References: <1436201338-14263-1-git-send-email-green@linuxhacker.ru> <1436201338-14263-19-git-send-email-green@linuxhacker.ru> <20150708084202.GN4341@mwanda> <20150714024313.GA24722@kroah.com> <188E1E93-DB4A-48FD-8A4B-E4887332CCE1@linuxhacker.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <188E1E93-DB4A-48FD-8A4B-E4887332CCE1@linuxhacker.ru> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2015 at 10:45:36PM -0400, Oleg Drokin wrote: > > On Jul 13, 2015, at 10:43 PM, Greg Kroah-Hartman wrote: > > > On Wed, Jul 08, 2015 at 11:45:59AM +0300, Dan Carpenter wrote: > >> On Mon, Jul 06, 2015 at 12:48:56PM -0400, green@linuxhacker.ru wrote: > >>> +static int libcfs_param_debug_mb_set(const char *val, > >>> + const struct kernel_param *kp) > >>> +{ > >>> + int rc; > >>> + unsigned num; > >>> + > >>> + rc = kstrtouint(val, 0, &num); > >>> + if (rc == -EINVAL) > >>> + return -EINVAL; > >> > >> Presumably, this is root only so using num uninitialized is not an > >> information leak. > > > > But it's not good, this should be a check for rc < 0 to make sure. > > > > Oleg, can you send a follow-on patch to fix this up? > > Sure. > Do you want it now or should I wait till you merge my previous bunch? I already merged your previous bunch :)