From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEvXp-0005gX-Mu for qemu-devel@nongnu.org; Tue, 14 Jul 2015 04:26:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEvXk-0000sE-7O for qemu-devel@nongnu.org; Tue, 14 Jul 2015 04:26:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEvXk-0000s5-17 for qemu-devel@nongnu.org; Tue, 14 Jul 2015 04:26:24 -0400 Date: Tue, 14 Jul 2015 09:26:21 +0100 From: Stefan Hajnoczi Message-ID: <20150714082621.GC17927@stefanha-thinkpad.redhat.com> References: <1436500012-32593-1-git-send-email-famz@redhat.com> <1436500012-32593-6-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="H8ygTp4AXg6deix2" Content-Disposition: inline In-Reply-To: <1436500012-32593-6-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 05/15] backup: Extract dirty bitmap handling as a separate function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Jeff Cody , qemu-devel@nongnu.org, Max Reitz , vsementsov@parallels.com, John Snow --H8ygTp4AXg6deix2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 10, 2015 at 11:46:42AM +0800, Fam Zheng wrote: > This will be reused by the coming new transactional completion code. >=20 > Signed-off-by: Fam Zheng > --- > block/backup.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) >=20 > diff --git a/block/backup.c b/block/backup.c > index 965654d..6e24384 100644 > --- a/block/backup.c > +++ b/block/backup.c > @@ -210,6 +210,21 @@ static void backup_iostatus_reset(BlockJob *job) > =20 > bdrv_iostatus_reset(s->target); > } > +static void backup_handle_dirty_bitmap(BackupBlockJob *job, int ret) "Dirty bitmap" is a general term. This block job uses dirty bitmaps besides the sync_bitmap. I suggest making the name clearer: backup_cleanup_sync_bitmap() --H8ygTp4AXg6deix2 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVpMetAAoJEJykq7OBq3PIuUAH/jNE2in92SaBvdlPrGr1Og0i oLDGXoSkCYO0Up6Kc129NLugyUh3kKQeJthlm285vlNeNSWFa1Lb4BXt+3FOFsDs Mgk1z0ere05LXF9JsUt/RCE9yM15XckzGCu01RJl+DP+ytodinzc36ZOjaxoNzjB eL9P4OYDP0QiK4yZJoJQXbd/MhrK3wGZjleUioYk/cGOeBtyooHvxsDNmbO/w5re saOkiF4OrwafDVf/iTnhdh8Iqx2hWx9bLKHXapZWlQmfITmjMyJ8ivhgo/hP60Ok FzmDHxaIB2YFBuQb5rNDm4WgwrbbthHuybmo61IaRvYojFqclMDjHzKXOw8tAIM= =wg1A -----END PGP SIGNATURE----- --H8ygTp4AXg6deix2--