From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 15/20] drm/i915: Always reset in intel_crtc_restore_mode Date: Tue, 14 Jul 2015 11:56:41 +0200 Message-ID: <20150714095641.GS3736@phenom.ffwll.local> References: <1436797833-11493-1-git-send-email-maarten.lankhorst@linux.intel.com> <1436797833-11493-16-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90CFD6E9E3 for ; Tue, 14 Jul 2015 02:54:01 -0700 (PDT) Received: by wgjx7 with SMTP id x7so4324212wgj.2 for ; Tue, 14 Jul 2015 02:54:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1436797833-11493-16-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdWwgMTMsIDIwMTUgYXQgMDQ6MzA6MjhQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQW5kIGdldCByaWQgb2YgdGhpbmdzIHRoYXQgYXJlIG5vIGxvbmdlciB0cnVl LiBUaGlzIGZ1bmN0aW9uIGlzIG9ubHkKPiB1c2VkIGZvciBmb3JjaW5nIGEgbW9kZXNldCB3aGVu IGVuY29kZXIgcHJvcGVydGllcyBhcmUgY2hhbmdlZC4KPiAKPiBCZWNhdXNlIHRoaXMgaXMgbm90 IHlldCBkb25lIGF0b21pY2FsbHksIGFzc3VtZSBhIGZ1bGwgbW9kZXNldCBpcwo+IG5lZWRlZCBh bmQgcmVzZXQgdGhlIGNydGMuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3Qg PG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KCnMvcmVzZXQvZm9yY2UgbW9kZXNl dC8gaW4gdGhlIHN1YmplY3Q/IFJlc2V0IGhhcyBhIGRpZmZlcmVudCBtZWFuaW5nIGZvcgptZSAu Li4KLURhbmllbAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IHwgNTggKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFu Z2VkLCAxNiBpbnNlcnRpb25zKCspLCA0MiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZjZjNjU3MDZjZWJmLi41OTlhZjc2ZDM0ZjYgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEzMjczLDYzICsxMzI3 MywzNyBAQCB2b2lkIGludGVsX2NydGNfcmVzdG9yZV9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0 YykKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmRldjsKPiAgCXN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiAtCXN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNv ZGVyOwo+IC0Jc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+IC0Jc3RydWN0IGRy bV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5lY3Rvcl9zdGF0ZTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpjcnRjX3N0YXRlOwo+ICsJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRl Owo+ICAJaW50IHJldDsKPiAgCj4gIAlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MoZGV2 KTsKPiAgCWlmICghc3RhdGUpIHsKPiAtCQlEUk1fREVCVUdfS01TKCJbQ1JUQzolZF0gbW9kZSBy ZXN0b3JlIGZhaWxlZCwgb3V0IG9mIG1lbW9yeSIsCj4gKwkJRFJNX0RFQlVHX0tNUygiW0NSVEM6 JWRdIGNydGMgcmVzdG9yZSBmYWlsZWQsIG91dCBvZiBtZW1vcnkiLAo+ICAJCQkgICAgICBjcnRj LT5iYXNlLmlkKTsKPiAgCQlyZXR1cm47Cj4gIAl9Cj4gIAo+IC0Jc3RhdGUtPmFjcXVpcmVfY3R4 ID0gZGV2LT5tb2RlX2NvbmZpZy5hY3F1aXJlX2N0eDsKPiAtCj4gLQkvKiBUaGUgZm9yY2UgcmVz dG9yZSBwYXRoIGluIHRoZSBIVyByZWFkb3V0IGNvZGUgcmVsaWVzIG9uIHRoZSBzdGFnZWQKPiAt CSAqIGNvbmZpZyBzdGlsbCBrZWVwaW5nIHRoZSB1c2VyIHJlcXVlc3RlZCBjb25maWcgd2hpbGUg dGhlIGFjdHVhbAo+IC0JICogc3RhdGUgaGFzIGJlZW4gb3ZlcndyaXR0ZW4gYnkgdGhlIGNvbmZp Z3VyYXRpb24gcmVhZCBmcm9tIEhXLiBXZQo+IC0JICogbmVlZCB0byBjb3B5IHRoZSBzdGFnZWQg Y29uZmlnIHRvIHRoZSBhdG9taWMgc3RhdGUsIG90aGVyd2lzZSB0aGUKPiAtCSAqIG1vZGUgc2V0 IHdpbGwganVzdCByZWFwcGx5IHRoZSBzdGF0ZSB0aGUgSFcgaXMgYWxyZWFkeSBpbi4gKi8KPiAt CWZvcl9lYWNoX2ludGVsX2VuY29kZXIoZGV2LCBlbmNvZGVyKSB7Cj4gLQkJaWYgKGVuY29kZXIt PmJhc2UuY3J0YyAhPSBjcnRjKQo+IC0JCQljb250aW51ZTsKPiArCXN0YXRlLT5hY3F1aXJlX2N0 eCA9IGRybV9tb2Rlc2V0X2xlZ2FjeV9hY3F1aXJlX2N0eChjcnRjKTsKPiAgCj4gLQkJZm9yX2Vh Y2hfaW50ZWxfY29ubmVjdG9yKGRldiwgY29ubmVjdG9yKSB7Cj4gLQkJCWlmIChjb25uZWN0b3It PmJhc2Uuc3RhdGUtPmJlc3RfZW5jb2RlciAhPQo+IC0JCQkgICAgJmVuY29kZXItPmJhc2UpCj4g LQkJCQljb250aW51ZTsKPiAtCj4gLQkJCWNvbm5lY3Rvcl9zdGF0ZSA9IGRybV9hdG9taWNfZ2V0 X2Nvbm5lY3Rvcl9zdGF0ZShzdGF0ZSwgJmNvbm5lY3Rvci0+YmFzZSk7Cj4gLQkJCWlmIChJU19F UlIoY29ubmVjdG9yX3N0YXRlKSkgewo+IC0JCQkJRFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIGFk ZCBbQ09OTkVDVE9SOiVkOiVzXSB0byBzdGF0ZTogJWxkXG4iLAo+IC0JCQkJCSAgICAgIGNvbm5l Y3Rvci0+YmFzZS5iYXNlLmlkLAo+IC0JCQkJCSAgICAgIGNvbm5lY3Rvci0+YmFzZS5uYW1lLAo+ IC0JCQkJCSAgICAgIFBUUl9FUlIoY29ubmVjdG9yX3N0YXRlKSk7Cj4gLQkJCQljb250aW51ZTsK PiAtCQkJfQo+ICtyZXRyeToKPiArCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9jcnRjX3N0 YXRlKHN0YXRlLCBjcnRjKTsKPiArCXJldCA9IFBUUl9FUlJfT1JfWkVSTyhjcnRjX3N0YXRlKTsK PiArCWlmICghcmV0KSB7Cj4gKwkJaWYgKCFjcnRjX3N0YXRlLT5hY3RpdmUpCj4gKwkJCWdvdG8g b3V0Owo+ICAKPiAtCQkJY29ubmVjdG9yX3N0YXRlLT5jcnRjID0gY3J0YzsKPiAtCQl9Cj4gKwkJ Y3J0Y19zdGF0ZS0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsKPiArCQlyZXQgPSBpbnRlbF9zZXRfbW9k ZShzdGF0ZSk7Cj4gIAl9Cj4gIAo+IC0JY3J0Y19zdGF0ZSA9IGludGVsX2F0b21pY19nZXRfY3J0 Y19zdGF0ZShzdGF0ZSwgdG9faW50ZWxfY3J0YyhjcnRjKSk7Cj4gLQlpZiAoSVNfRVJSKGNydGNf c3RhdGUpKSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIGFkZCBbQ1JUQzolZF0gdG8g c3RhdGU6ICVsZFxuIiwKPiAtCQkJICAgICAgY3J0Yy0+YmFzZS5pZCwgUFRSX0VSUihjcnRjX3N0 YXRlKSk7Cj4gLQkJZHJtX2F0b21pY19zdGF0ZV9mcmVlKHN0YXRlKTsKPiAtCQlyZXR1cm47Cj4g KwlpZiAocmV0ID09IC1FREVBRExLKSB7Cj4gKwkJZHJtX2F0b21pY19zdGF0ZV9jbGVhcihzdGF0 ZSk7Cj4gKwkJZHJtX21vZGVzZXRfYmFja29mZihzdGF0ZS0+YWNxdWlyZV9jdHgpOwo+ICsJCWdv dG8gcmV0cnk7Cj4gIAl9Cj4gIAo+IC0JZHJtX21vZGVfY29weSgmY3J0Y19zdGF0ZS0+YmFzZS5t b2RlLCAmY3J0Yy0+bW9kZSk7Cj4gLQo+IC0JaW50ZWxfbW9kZXNldF9zZXR1cF9wbGFuZV9zdGF0 ZShzdGF0ZSwgY3J0YywgJmNydGMtPm1vZGUsCj4gLQkJCQkJY3J0Yy0+cHJpbWFyeS0+ZmIsIGNy dGMtPngsIGNydGMtPnkpOwo+IC0KPiAtCXJldCA9IGludGVsX3NldF9tb2RlKHN0YXRlKTsKPiAg CWlmIChyZXQpCj4gK291dDoKPiAgCQlkcm1fYXRvbWljX3N0YXRlX2ZyZWUoc3RhdGUpOwo+ICB9 Cj4gIAo+IC0tIAo+IDIuMS4wCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=