From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: "Damian, Alexandru" <alexandru.damian@intel.com>
Cc: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: [review-request] ed/toaster/misc
Date: Tue, 14 Jul 2015 16:37:48 +0300 [thread overview]
Message-ID: <20150714133748.GB25220@linux.intel.com> (raw)
In-Reply-To: <CAJ2CSBsbh7rZiLkY5xg5xU5AfcuOrefvTq7CSUSqCyJQ+5Vi9w@mail.gmail.com>
Hi Alex,
Thank you for review. My answers are below.
On Tue, Jul 14, 2015 at 12:18:02PM +0100, Damian, Alexandru wrote:
> Hi,
>
> I have some comments below:
>
> *toaster: get rid of _createdirpath function*
>
> os.mkdirs is missing the mode specification; I am not sure it matters,
> though.
I think it shouldn't matter, but it doesn't look very clear as I was
lazy and put both changes in one commit. Thanks to point that out to me.
I've added mode to the call and updated the branch.
>
>
> *toaster: Wait for toaster gui to come*
>
> I am not sure which logger should to be used here; the reason for
> changing the logger in the first place (which was originally defined as
> "BitBake" was that the "BitBake" logger settings are modified in
> bitbake/lib/bb/__init__.py, and it is targeted at the inner Bitbake core;
> some updates there changed the original output, with output disappearing
> from the console being an obvious effect.
> Messing with "BitBake" logger settings with this may have side effects
> throught the bitbake code, so I refrained from touching that
>
> I considered using the "toaster" logger that is defined in
> bitbake/lib/toaster/toastermain/settings.py and outputs strictly to
> console; I felt likewise reluctant to use this logger because changing it
> to output to a file would be affect the way the django application is
> logging.
>
> ToasterLogger is not defined anywhere, and this is why I used it here.
And this apparently didn't work out well and caused "ToasterUI waiting for
events" message to disappear from toaster_ui.log and be controller
failing after 10 unsuccessful attempts to find this message in the log.
> I am not sure I understand the root cause of why the code breaks when using
> "ToasterLogger" instead of "BitBake"; can you please assess the root cause
> and get a solution to have messages properly logged to the toaster_ui.log
> file using a logger that's not BitBake ?
OK, I'll look at it. Meanwhile I'd suggest to accept this change because
it's much better than previous one. It doesn't fix the root case, but it
reverts the change that caused the bug.
Regards,
Ed
> On Mon, Jul 13, 2015 at 5:47 PM, Michael Wood <michael.g.wood@intel.com>
> wrote:
>
> > On 10/07/15 15:48, Ed Bartosh wrote:
> >
> >> Hi reviewers,
> >>
> >> Please review fix for YOCTO: #7965: Wait for toaster gui to come
> >> and couple of other changes:
> >> 1. tiny refactoring change: get rid of _createdirpath function
> >> 2. and small fix: Fix usage of wrong variables
> >>
> >> --
> >> Regards,
> >> Ed
> >>
> >
> > * 7cee08d toaster: get rid of _createdirpath function
> > * eae47f7 toaster: Fix usage of wrong variables
> > * 321d6ae toaster: Wait for toaster gui to come
> >
> > Looks fine to me, though not familiar enough with build stuff to fully OK
> > this branch.
> >
> > While you're in localhostbecontroller
> >
> > We could also get rid of
> >
> > def _shellcmd(self, command, cwd = None):
> > if cwd is None:
> > cwd = self.be.sourcedir
> >
> > #logger.debug("lbc_shellcmmd: (%s) %s" % (cwd, command))
> > p = subprocess.Popen(command, cwd = cwd, shell=True,
> > stdout=subprocess.PIPE, stderr=subprocess.PIPE)
> > (out,err) = p.communicate()
> > p.wait()
> > if p.returncode:
> > if len(err) == 0:
> > err = "command: %s \n%s" % (command, out)
> > else:
> > err = "command: %s \n%s" % (command, err)
> > #logger.warn("localhostbecontroller: shellcmd error %s" % err)
> > raise ShellCmdException(err)
> > else:
> > #logger.debug("localhostbecontroller: shellcmd success")
> > return out
> >
> >
> > I believe with:
> >
> > subprocess.check_output
> >
> > Thanks,
> >
> > Michael
> >
> > --
> > _______________________________________________
> > toaster mailing list
> > toaster@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/toaster
> >
>
>
>
> --
> Alex Damian
> Yocto Project
> SSG / OTC
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
--
--
Regards,
Ed
next prev parent reply other threads:[~2015-07-14 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 14:48 [review-request] ed/toaster/misc Ed Bartosh
2015-07-13 16:47 ` Michael Wood
2015-07-14 11:18 ` Damian, Alexandru
2015-07-14 13:37 ` Ed Bartosh [this message]
2015-07-19 19:35 ` Ed Bartosh
2015-07-14 13:06 ` Ed Bartosh
2015-07-14 13:37 ` Damian, Alexandru
2015-07-14 13:52 ` Ed Bartosh
2015-07-24 16:22 ` Ed Bartosh
2015-07-27 12:26 ` Damian, Alexandru
2015-07-28 12:35 ` Ed Bartosh
2015-07-28 14:00 ` Damian, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714133748.GB25220@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=alexandru.damian@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.