All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	Yong Y Wang <yong.y.wang@intel.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Yang Z Zhang <yang.z.zhang@intel.com>,
	Feng Wu <feng.wu@intel.com>
Subject: Re: Requesting for freeze exception for VT-d posted-interrupts
Date: Tue, 14 Jul 2015 16:02:58 +0100	[thread overview]
Message-ID: <20150714150258.GO4152@zion.uk.xensource.com> (raw)
In-Reply-To: <55A53CF60200007800090D1C@mail.emea.novell.com>

On Tue, Jul 14, 2015 at 03:46:46PM +0100, Jan Beulich wrote:
> >>> On 14.07.15 at 16:17, <wei.liu2@citrix.com> wrote:
> > On Tue, Jul 14, 2015 at 11:09:15AM +0100, Jan Beulich wrote:
> >> >>> On 14.07.15 at 11:21, <wei.liu2@citrix.com> wrote:
> >> > On Tue, Jul 14, 2015 at 05:51:02AM +0000, Wu, Feng wrote:
> >> >> Is it possible to get to 4.6 if making this feature default off?
> >> > 
> >> > Note that I'm not the only one who makes the decision and I can't speak
> >> > for maintainers. The first thing you ought to do is to convince
> >> > maintainers, not me.
> >> > 
> >> > If you ask for my opinion -- I don't see a point in releasing feature
> >> > with security flaw in design, even if it is off by default. 
> >> 
> >> It was actually me who suggested that by flagging this experimental
> >> and defaulting it to off, chances would increase for this to be allowed
> >> in without said issue fixed.
> > 
> > Are you satisfied with that?  Currently I only know from this email
> > there is concern with regard to security but I don't know what it is and
> > how big an impact it can possibly have.
> > 
> > I could maybe go dig up that series and try to understand what is the
> > security implication, but it would take a long time and I'm not sure I
> > have the right technical background to make the call.
> 
> The thing is that the way vCPU-s are being put on lists attached to
> pCPU-s, in a pathological case (which can be "helped" by a malicious
> tool stack) all vCPU-s could pile up on one such list. List traversal (in
> an interrupt handler) could then take (almost) arbitrarily long.

You mentioned "malicious toolstack", does that mean this feature, if on,
doesn't expose new attack vector to malicious guest?

And what do you mean by "malicious toolstack"? I don't see patches
related to toolstack.

> 
> Otoh one wouldn't expect lists to grow too large on well behaved,
> properly operating systems. And hence for the sake of experimenting
> with the feature or even using it in known well behaved production
> environments it would seem reasonable to allow the feature to be
> there.
> 

Right.

Wei.

> Jan

  reply	other threads:[~2015-07-14 15:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  6:55 Requesting for freeze exception for VT-d posted-interrupts Wu, Feng
2015-07-13  9:05 ` Jan Beulich
2015-07-13 11:00 ` Wei Liu
2015-07-14  5:51   ` Wu, Feng
2015-07-14  9:21     ` Wei Liu
2015-07-14 10:09       ` Jan Beulich
2015-07-14 14:17         ` Wei Liu
2015-07-14 14:46           ` Jan Beulich
2015-07-14 15:02             ` Wei Liu [this message]
2015-07-14 16:01               ` Jan Beulich
2015-07-15 15:46                 ` Wei Liu
2015-07-15 22:48                   ` Wu, Feng
2015-07-17  9:28                     ` Wei Liu
2015-07-13 15:38 ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150714150258.GO4152@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=feng.wu@intel.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    --cc=yong.y.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.