From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753130AbbGNPhD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Jul 2015 11:37:03 -0400
Received: from mail.kernel.org ([198.145.29.136]:44814 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751900AbbGNPhB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Jul 2015 11:37:01 -0400
Date: Tue, 14 Jul 2015 12:36:57 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: ast@plumgrid.com, linux-kernel@vger.kernel.org, lizefan@huawei.com,
        hekuang@huawei.com, xiakaixu@huawei.com, pi3orama@163.com
Subject: perf test LLVM was: Re: [GIT PULL 00/39] perf tools: filtering
 events using eBPF programs
Message-ID: <20150714153657.GL2885@kernel.org>
References: <1436445342-1402-1-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1436445342-1402-1-git-send-email-wangnan0@huawei.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Jul 09, 2015 at 12:35:03PM +0000, Wang Nan escreveu:
> Hi Arnaldo,
> 
> The following changes since commit 3381a29cbec5447086c0f726ee9a88c02e60becc:
> 
>   bpf tools: Collect map definitions from 'maps' section (2015-07-07 13:41:45 -0300)
> 
> are available in the git repository at:
> 
>   https://github.com/WangNan0/linux.git perf/ebpf-for-acme
> 
> for you to fetch changes up to 072b826c5dc6b2031f4f21c59c57eb6ca1dfa7c0:

So, this is really nice:

38: Test LLVM searching and compiling                        :ERROR:	unable to find clang.
Hint:	Try to install latest clang/llvm to support BPF. Check your $PATH
     	and 'clang-path' option in [llvm] section of ~/.perfconfig.
     	LLVM 3.7 or newer is required. Which can be found from http://llvm.org
     	You may want to try git trunk:
     		git clone http://llvm.org/git/llvm.git
     		     and
     		git clone http://llvm.org/git/clang.git

     	Or fetch the latest clang/llvm 3.7 from pre-built llvm packages for
     	debian/ubuntu:
     		http://llvm.org/apt

     	If you are using old version of clang, change 'clang-bpf-cmd-template'
     	option in [llvm] section of ~/.perfconfig to:

     	  "$CLANG_EXEC $CLANG_OPTIONS $KERNEL_INC_OPTIONS \
     	     -working-directory $WORKING_DIR -c $CLANG_SOURCE \
     	     -emit-llvm -o - | /path/to/llc -march=bpf -filetype=obj -o -"
     	(Replace /path/to/llc with path to your llc)

 FAILED!
[acme@zoo linux]$ 

I have the trees cloned and plan to follow these instructions to have this test
passing, to then move on to the next patches, but one request, please change
the above to produce:

38: Test LLVM searching and compiling                        :(no clang) Ok	run 'perf test -v LLVM' for instructions on having a clang environment

'perf test' will accept either '38' or any substring in the test description and
will run just the ones specified, and with -v we will spare people not interested
in this eBPF support of these nice verbose instructions :-)

If we find clang but then fail to build, ok, then this is a hard error, I think,
and 'perf test' should FAIL that test.

Regards,

- Arnaldo