From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753270AbbGNTUD (ORCPT ); Tue, 14 Jul 2015 15:20:03 -0400 Received: from mail.kernel.org ([198.145.29.136]:56303 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301AbbGNTUB (ORCPT ); Tue, 14 Jul 2015 15:20:01 -0400 Date: Tue, 14 Jul 2015 12:19:58 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Fan Li Subject: Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in separated file Message-ID: <20150714191958.GA78887@jaegeuk-mac02> References: <00b001d0b964$e403d930$ac0b8b90$@samsung.com> <00f201d0be1d$78aa7370$69ff5a50$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00f201d0be1d$78aa7370$69ff5a50$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2015 at 06:10:50PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -----Original Message----- > > From: Chao Yu [mailto:yuchaochina@hotmail.com] > > Sent: Thursday, July 09, 2015 12:16 AM > > To: 'Jaegeuk Kim' > > Cc: linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > > Subject: Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in separated file > > > > >From 8956df8fa1a669e8e476456e4afe0eccd8174684 Mon Sep 17 00:00:00 2001 > > From: Chao Yu > > Date: Wed, 8 Jul 2015 20:49:05 +0800 > > Subject: [PATCH] f2fs: maintain extent cache in separated file > > > > This patch moves extent cache related code from data.c into extent_cache.c > > since extent cache is independent feature, and its codes are not relate to > > others in data.c, it's better for us to maintain them in separated place. > > > > There is no functionality change, but several small coding style fixes > > including: > > * rename __drop_largest_extent to f2fs_drop_largest_extent for exporting; > > * rename misspelled word 'untill' to 'until'; > > * remove unneeded 'return' in the end of f2fs_destroy_extent_tree(). > > > > I think commit 0b84ceec9891 ("f2fs: don't try to split extents shorter than > F2FS_MIN_EXTENT_LEN") is conflict with commit 392a1c419916 ("f2fs: maintain > extent cache in separated file"), and it's not well resolved in dev-test. > > in commit 392a1c419916 ("f2fs: maintain extent cache in separated file"): > > - if (dei.len > F2FS_MIN_EXTENT_LEN) { > > + if (dei.len > 1) { Good catch. Not a big deal, so I just resolved that in this patch. :) Thanks, > > So how about merging this patch (f2fs: maintain extent cache in separated file) > first, and then merge Fan's patch? because one line modification in extent_cache.c > for fixing conflict seems much easier. > > BTW, I have already fixed the building error in this patch, you can directly > use the last sent patch in this thread showed in below link. :) > > http://sourceforge.net/p/linux-f2fs/mailman/message/34277570/ > > Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH RESEND] f2fs: maintain extent cache in separated file Date: Tue, 14 Jul 2015 12:19:58 -0700 Message-ID: <20150714191958.GA78887@jaegeuk-mac02> References: <00b001d0b964$e403d930$ac0b8b90$@samsung.com> <00f201d0be1d$78aa7370$69ff5a50$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1ZF5kN-0000Zu-JP for linux-f2fs-devel@lists.sourceforge.net; Tue, 14 Jul 2015 19:20:07 +0000 Received: from mail.kernel.org ([198.145.29.136]) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1ZF5kM-0001YM-7P for linux-f2fs-devel@lists.sourceforge.net; Tue, 14 Jul 2015 19:20:07 +0000 Content-Disposition: inline In-Reply-To: <00f201d0be1d$78aa7370$69ff5a50$@samsung.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net On Tue, Jul 14, 2015 at 06:10:50PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -----Original Message----- > > From: Chao Yu [mailto:yuchaochina@hotmail.com] > > Sent: Thursday, July 09, 2015 12:16 AM > > To: 'Jaegeuk Kim' > > Cc: linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > > Subject: Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in separated file > > > > >From 8956df8fa1a669e8e476456e4afe0eccd8174684 Mon Sep 17 00:00:00 2001 > > From: Chao Yu > > Date: Wed, 8 Jul 2015 20:49:05 +0800 > > Subject: [PATCH] f2fs: maintain extent cache in separated file > > > > This patch moves extent cache related code from data.c into extent_cache.c > > since extent cache is independent feature, and its codes are not relate to > > others in data.c, it's better for us to maintain them in separated place. > > > > There is no functionality change, but several small coding style fixes > > including: > > * rename __drop_largest_extent to f2fs_drop_largest_extent for exporting; > > * rename misspelled word 'untill' to 'until'; > > * remove unneeded 'return' in the end of f2fs_destroy_extent_tree(). > > > > I think commit 0b84ceec9891 ("f2fs: don't try to split extents shorter than > F2FS_MIN_EXTENT_LEN") is conflict with commit 392a1c419916 ("f2fs: maintain > extent cache in separated file"), and it's not well resolved in dev-test. > > in commit 392a1c419916 ("f2fs: maintain extent cache in separated file"): > > - if (dei.len > F2FS_MIN_EXTENT_LEN) { > > + if (dei.len > 1) { Good catch. Not a big deal, so I just resolved that in this patch. :) Thanks, > > So how about merging this patch (f2fs: maintain extent cache in separated file) > first, and then merge Fan's patch? because one line modification in extent_cache.c > for fixing conflict seems much easier. > > BTW, I have already fixed the building error in this patch, you can directly > use the last sent patch in this thread showed in below link. :) > > http://sourceforge.net/p/linux-f2fs/mailman/message/34277570/ > > Thanks, ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/