From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752246AbbGOCO0 (ORCPT ); Tue, 14 Jul 2015 22:14:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48218 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbbGOCOY (ORCPT ); Tue, 14 Jul 2015 22:14:24 -0400 Date: Tue, 14 Jul 2015 19:14:23 -0700 From: Greg KH To: Fabio Falzoi Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] Staging: fbtft: Use a helper function to set set_addr_win op Message-ID: <20150715021423.GD4788@kroah.com> References: <1435646597-7612-1-git-send-email-fabio.falzoi84@gmail.com> <1435646597-7612-7-git-send-email-fabio.falzoi84@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435646597-7612-7-git-send-email-fabio.falzoi84@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2015 at 08:43:13AM +0200, Fabio Falzoi wrote: > Use a helper function to choose which set_addr_win implementation to > use, based on the value of the setaddrwin module parameter. > > Signed-off-by: Fabio Falzoi > --- > drivers/staging/fbtft/flexfb.c | 47 +++++++++++++++++++++++++----------------- > 1 file changed, 28 insertions(+), 19 deletions(-) Again, why? I need a maintainer of the code to ack any of these...