From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFJAa-0007U2-4I for qemu-devel@nongnu.org; Wed, 15 Jul 2015 05:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFJAV-0003md-BY for qemu-devel@nongnu.org; Wed, 15 Jul 2015 05:40:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFJAV-0003mM-6j for qemu-devel@nongnu.org; Wed, 15 Jul 2015 05:39:59 -0400 Date: Wed, 15 Jul 2015 15:09:45 +0530 From: Amit Shah Message-ID: <20150715093945.GT10280@grmbl.mre> References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com> <1434450415-11339-18-git-send-email-dgilbert@redhat.com> <5580443A.6050306@redhat.com> <20150616155816.GD2119@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150616155816.GD2119@work-vm> Subject: Re: [Qemu-devel] [PATCH v7 17/42] Add migration-capability boolean for postcopy-ram. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, pbonzini@redhat.com, david@gibson.dropbear.id.au On (Tue) 16 Jun 2015 [16:58:17], Dr. David Alan Gilbert wrote: > * Eric Blake (eblake@redhat.com) wrote: > > On 06/16/2015 04:26 AM, Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The 'postcopy ram' capability allows postcopy migration of RAM; > > > note that the migration starts off in precopy mode until > > > postcopy mode is triggered (see the migrate_start_postcopy > > > patch later in the series). > > > > > > Signed-off-by: Dr. David Alan Gilbert > > > --- > > > include/migration/migration.h | 1 + > > > migration/migration.c | 23 +++++++++++++++++++++++ > > > qapi-schema.json | 6 +++++- > > > 3 files changed, 29 insertions(+), 1 deletion(-) > > > > > > > > +++ b/qapi-schema.json > > > @@ -526,11 +526,15 @@ > > > # @auto-converge: If enabled, QEMU will automatically throttle down the guest > > > # to speed up convergence of RAM migration. (since 1.6) > > > # > > > +# @x-postcopy-ram: Start executing on the migration target before all of RAM has > > > +# been migrated, pulling the remaining pages along as needed. NOTE: If > > > +# the migration fails during postcopy the VM will fail. (since 2.4) > > > > Marking it experimental because it might change? Or is the interface > > pretty stable, but you want more testing time to minimize bugs? > > It's easy enough to remove the x- once we're all happy; it seems pretty > stable at the moment but when we're done I'll just submit a one liner to take the x- > off. We shouldn't mark it stable till we have a released kernel (which freezes the kernel API for us). We could pick this patchset without a released kernel, but this will have to remain x- if that happens. Amit