From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Kershner, David A" <David.Kershner@unisys.com>
Cc: "Romer, Benjamin M" <Benjamin.Romer@unisys.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
"Jes.Sorensen@redhat.com" <Jes.Sorensen@redhat.com>,
*S-Par-Maintainer <SParMaintainer@unisys.com>
Subject: Re: [PATCH] staging: unisys: Add s-Par visorhba
Date: Wed, 15 Jul 2015 21:34:42 +0300 [thread overview]
Message-ID: <20150715183442.GE5784@mwanda> (raw)
In-Reply-To: <63123ea0c059467c9cb7bd20a6cc2247@US-EXCH13-1.na.uis.unisys.com>
On Wed, Jul 15, 2015 at 04:53:24PM +0000, Kershner, David A wrote:
> ERROR: Macros with complex values should be enclosed in parentheses
> #31: FILE: drivers/staging/unisys/visorhba/visorhba_main.c:157:
> +#define for_each_vdisk_match(iter, list, match) \
> + for (iter = &list->head; iter->next; iter = iter->next) \
> + if (iter->channel == match->channel && \
> + iter->id == match->id && \
> + iter->lun == match->lun)
>
> total: 1 errors, 0 warnings, 0 checks, 275 lines checked
>
> Your patch has style problems, please review.
>
> Any ideas what needs to be wrapped to resolved the checkpatch error?
It's a false positive, just ignore the warning.
regards,
dan carpenter
next prev parent reply other threads:[~2015-07-15 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 18:38 [PATCH] staging: unisys: Add s-Par visorhba Benjamin Romer
2015-07-15 1:50 ` Greg KH
2015-07-15 12:16 ` Dan Carpenter
2015-07-15 16:53 ` Kershner, David A
2015-07-15 18:34 ` Dan Carpenter [this message]
2015-07-15 19:48 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715183442.GE5784@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Benjamin.Romer@unisys.com \
--cc=David.Kershner@unisys.com \
--cc=Jes.Sorensen@redhat.com \
--cc=SParMaintainer@unisys.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.