From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v6 0/6] virtio PCI Port Hotplug Date: Thu, 16 Jul 2015 17:53:52 -0700 Message-ID: <20150716175352.4acce1bc@urahara> References: <1436968265-14362-1-git-send-email-bernard.iremonger@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Bernard Iremonger Return-path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id C8ADC5A51 for ; Fri, 17 Jul 2015 02:53:44 +0200 (CEST) Received: by padck2 with SMTP id ck2so51068272pad.0 for ; Thu, 16 Jul 2015 17:53:44 -0700 (PDT) In-Reply-To: <1436968265-14362-1-git-send-email-bernard.iremonger@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 15 Jul 2015 14:50:59 +0100 Bernard Iremonger wrote: > Changes in V6: > Rebase. > Use queue_release function in dev_uninit function (patch 5) > Set vq to NULL in queue release function. > Move previous patch 5 to patch 6. > > > Changes in V5: > Rebase. > Add proper queue release patch (patch 3). > Reorder patches, moved previous patch 3 to patch 4, > moved previous patch 4 to patch 5. > > Changes in V4: > Rebase to latest code. > Move freeing of queue memory from uninit() function to close() function. > Change to testpmd to facilate testing on VM. > > Changes in V3: > Rebase to latest code. > Free queue memory in uninit() function. > > Changes in V2: > Rebase to use new drivers directory. > > Bernard Iremonger (6): > virtio: add support for PCI Port Hotplug > virtio: check vq parameter in virtqueue_detatch_unused() function > virtio: add proper queue release > virtio: free queue memory in virtio_dev_close() > virtio: use queue_release in dev_uninit > test-pmd: remove call to rte_eth_promiscuous_disable() from > detach_port() > > app/test-pmd/testpmd.c | 4 +- > drivers/net/virtio/virtio_ethdev.c | 120 +++++++++++++++++++++++++++++-------- > drivers/net/virtio/virtio_ethdev.h | 8 ++- > drivers/net/virtio/virtio_rxtx.c | 12 ++++ > drivers/net/virtio/virtqueue.c | 14 +++-- > 5 files changed, 123 insertions(+), 35 deletions(-) > Looks good thanks. Acked-by: Stephen Hemminger