From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757907AbbGQMvx (ORCPT ); Fri, 17 Jul 2015 08:51:53 -0400 Received: from smtprelay0019.hostedemail.com ([216.40.44.19]:57835 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757488AbbGQMvv (ORCPT ); Fri, 17 Jul 2015 08:51:51 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2691:3138:3139:3140:3141:3142:3622:3865:3870:3872:3873:3874:4184:4321:4605:5007:6120:6261:7875:8603:10004:10400:10848:10967:11026:11232:11658:11914:12296:12517:12519:12740:13069:13311:13357:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: walk73_4a315e8d09048 X-Filterd-Recvd-Size: 2140 Date: Fri, 17 Jul 2015 08:51:48 -0400 From: Steven Rostedt To: Mark Rutland Cc: Jungseok Lee , Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , AKASHI Takahiro , "broonie@kernel.org" , "david.griego@linaro.org" , "olof@lixom.net" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC 2/3] arm64: refactor save_stack_trace() Message-ID: <20150717085148.70e3ad0d@gandalf.local.home> In-Reply-To: <20150717124054.GE26091@leverpostej> References: <55A646EE.6030402@linaro.org> <20150715105536.42949ea9@gandalf.local.home> <20150715121337.3b31aa84@gandalf.local.home> <55A6FA82.9000901@linaro.org> <55A703F3.8050203@linaro.org> <20150716102405.2cc8c406@gandalf.local.home> <12F47692-3010-4886-B87D-3D7820609177@gmail.com> <20150716113115.45a17f17@gandalf.local.home> <20150716121658.7982fdf5@gandalf.local.home> <20150717124054.GE26091@leverpostej> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jul 2015 13:40:54 +0100 Mark Rutland wrote: > Hi, > > > @@ -354,7 +330,7 @@ static int t_show(struct seq_file *m, vo > > seq_printf(m, " Depth Size Location" > > " (%d entries)\n" > > " ----- ---- --------\n", > > - max_stack_trace.nr_entries - 1); > > + max_stack_trace.nr_entries); > > I believe you'll want the same fix in print_max_stack, given it's a > carbon copy. Yep, thanks for pointing that out. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt@goodmis.org (Steven Rostedt) Date: Fri, 17 Jul 2015 08:51:48 -0400 Subject: [RFC 2/3] arm64: refactor save_stack_trace() In-Reply-To: <20150717124054.GE26091@leverpostej> References: <55A646EE.6030402@linaro.org> <20150715105536.42949ea9@gandalf.local.home> <20150715121337.3b31aa84@gandalf.local.home> <55A6FA82.9000901@linaro.org> <55A703F3.8050203@linaro.org> <20150716102405.2cc8c406@gandalf.local.home> <12F47692-3010-4886-B87D-3D7820609177@gmail.com> <20150716113115.45a17f17@gandalf.local.home> <20150716121658.7982fdf5@gandalf.local.home> <20150717124054.GE26091@leverpostej> Message-ID: <20150717085148.70e3ad0d@gandalf.local.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 17 Jul 2015 13:40:54 +0100 Mark Rutland wrote: > Hi, > > > @@ -354,7 +330,7 @@ static int t_show(struct seq_file *m, vo > > seq_printf(m, " Depth Size Location" > > " (%d entries)\n" > > " ----- ---- --------\n", > > - max_stack_trace.nr_entries - 1); > > + max_stack_trace.nr_entries); > > I believe you'll want the same fix in print_max_stack, given it's a > carbon copy. Yep, thanks for pointing that out. -- Steve