From: "Daniel P. Berrange" <berrange@redhat.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vnc: fix vnc client authentication
Date: Fri, 17 Jul 2015 11:51:04 +0100 [thread overview]
Message-ID: <20150717105103.GE4835@redhat.com> (raw)
In-Reply-To: <1436878300-13284-1-git-send-email-w.bumiller@proxmox.com>
On Tue, Jul 14, 2015 at 02:51:40PM +0200, Wolfgang Bumiller wrote:
> Commit 800567a61 updated the code to the generic crypto API
> and mixed up encrypt and decrypt functions in
> procotol_client_auth_vnc.
> (Used to be: deskey(key, EN0) which encrypts, and was
> changed to qcrypto_cipher_decrypt in 800567a61.)
> Changed it to qcrypto_cipher_encrypt now.
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> ui/vnc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 94e4f19..1483958 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2551,7 +2551,7 @@ static int protocol_client_auth_vnc(VncState *vs, uint8_t *data, size_t len)
> goto reject;
> }
>
> - if (qcrypto_cipher_decrypt(cipher,
> + if (qcrypto_cipher_encrypt(cipher,
> vs->challenge,
> response,
> VNC_AUTH_CHALLENGE_SIZE,
I see its already merged while i was on holiday, but none the
less
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Thanks for fixing my stupid typo.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
prev parent reply other threads:[~2015-07-17 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 12:51 [Qemu-devel] [PATCH] vnc: fix vnc client authentication Wolfgang Bumiller
2015-07-17 10:51 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717105103.GE4835@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.