From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 5EE39E009E6; Sun, 19 Jul 2015 12:35:21 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.55.52.115 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id EB003E006EE for ; Sun, 19 Jul 2015 12:35:19 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 19 Jul 2015 12:35:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,504,1432623600"; d="scan'208";a="731741045" Received: from linux.intel.com ([10.23.219.25]) by orsmga001.jf.intel.com with ESMTP; 19 Jul 2015 12:35:19 -0700 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.65]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id CAF3F6A4083; Sun, 19 Jul 2015 12:34:35 -0700 (PDT) Date: Sun, 19 Jul 2015 22:35:13 +0300 From: Ed Bartosh To: "Damian, Alexandru" Message-ID: <20150719193513.GA1373@linux.intel.com> References: <20150710144844.GA14439@linux.intel.com> <55A3EBB9.5060109@intel.com> <20150714133748.GB25220@linux.intel.com> MIME-Version: 1.0 In-Reply-To: <20150714133748.GB25220@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] ed/toaster/misc X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: ed.bartosh@linux.intel.com List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2015 19:35:21 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Alex, > > *toaster: Wait for toaster gui to come* > > > > I am not sure which logger should to be used here; the reason for > > changing the logger in the first place (which was originally defined as > > "BitBake" was that the "BitBake" logger settings are modified in > > bitbake/lib/bb/__init__.py, and it is targeted at the inner Bitbake core; > > some updates there changed the original output, with output disappearing > > from the console being an obvious effect. > > Messing with "BitBake" logger settings with this may have side effects > > throught the bitbake code, so I refrained from touching that > > > > I considered using the "toaster" logger that is defined in > > bitbake/lib/toaster/toastermain/settings.py and outputs strictly to > > console; I felt likewise reluctant to use this logger because changing it > > to output to a file would be affect the way the django application is > > logging. > > > > ToasterLogger is not defined anywhere, and this is why I used it here. > And this apparently didn't work out well and caused "ToasterUI waiting for > events" message to disappear from toaster_ui.log and be controller > failing after 10 unsuccessful attempts to find this message in the log. > > > I am not sure I understand the root cause of why the code breaks when using > > "ToasterLogger" instead of "BitBake"; can you please assess the root cause > > and get a solution to have messages properly logged to the toaster_ui.log > > file using a logger that's not BitBake ? > OK, I'll look at it. Meanwhile I'd suggest to accept this change because > it's much better than previous one. It doesn't fix the root case, but it > reverts the change that caused the bug. > The root cause of the issue was that logging level was not set for the ToasterLogger. I've updated the patch: https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ed/toaster/misc&id=6d1ddedaef28c0f17c2b821c3ceb077641fab772 Please, review. -- Regards, Ed