From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54315)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZHRzd-0002bD-1t
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 03:29:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZHRzX-0006o7-Vu
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 03:29:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43402)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZHRzX-0006nd-QS
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 03:29:31 -0400
Date: Tue, 21 Jul 2015 12:59:05 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150721072905.GE10280@grmbl.mre>
References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com>
	<1434450415-11339-22-git-send-email-dgilbert@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1434450415-11339-22-git-send-email-dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 21/42] postcopy: OS support test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, pbonzini@redhat.com, david@gibson.dropbear.id.au

On (Tue) 16 Jun 2015 [11:26:34], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Provide a check to see if the OS we're running on has all the bits
> needed for postcopy.
> 
> Creates postcopy-ram.c which will get most of the other helpers we need.
> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> @@ -1165,6 +1166,10 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
>          return -1;
>      }
>  
> +    if (!postcopy_ram_supported_by_host()) {
> +        return -1;
> +    }
> +

So this is just advise: if we receive this, and we can't handle
postcopy, we're going to abort migration?  Shouldn't we continue and
let src know that we can't accept postcopy?  ie the problem is
currently punted to higher levels, should we try to handle it
ourselves?



		Amit