From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHUrj-0003vL-W4 for qemu-devel@nongnu.org; Tue, 21 Jul 2015 06:33:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHUre-00089P-QB for qemu-devel@nongnu.org; Tue, 21 Jul 2015 06:33:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHUre-000894-LP for qemu-devel@nongnu.org; Tue, 21 Jul 2015 06:33:34 -0400 Date: Tue, 21 Jul 2015 16:03:07 +0530 From: Amit Shah Message-ID: <20150721103307.GH10280@grmbl.mre> References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com> <1434450415-11339-24-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434450415-11339-24-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, pbonzini@redhat.com, david@gibson.dropbear.id.au On (Tue) 16 Jun 2015 [11:26:36], Dr. David Alan Gilbert (git) wrote: > - if (s->state == MIGRATION_STATUS_ACTIVE || > - s->state == MIGRATION_STATUS_SETUP) { > + if (migration_already_active(s)) { (I know, not introduced here, but:) A better name is migration_is_active() > +bool migration_postcopy_phase(MigrationState *s) > +{ > + return (s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE); > +} And this is better named migration_in_postcopy() otherwise, Reviewed-by: Amit Shah Amit