From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZHV0f-0005aP-Jk
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 06:42:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZHV0c-0003rR-4f
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 06:42:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47851)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZHV0b-0003r0-Vf
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 06:42:50 -0400
Date: Tue, 21 Jul 2015 16:12:25 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150721104225.GI10280@grmbl.mre>
References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com>
	<1434450415-11339-25-git-send-email-dgilbert@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1434450415-11339-25-git-send-email-dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 24/42] Add
	qemu_savevm_state_complete_postcopy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, pbonzini@redhat.com, david@gibson.dropbear.id.au

On (Tue) 16 Jun 2015 [11:26:37], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Add qemu_savevm_state_complete_postcopy to complement
> qemu_savevm_state_complete_precopy together with a new
> save_live_complete_postcopy method on devices.
> 
> The save_live_complete_precopy method is called on
> all devices during a precopy migration, and all non-postcopy
> devices during a postcopy migration at the transition.
> 
> The save_live_complete_postcopy method is called at
> the end of postcopy for all postcopiable devices.
> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Reviewed-by: Amit Shah <amit.shah@redhat.com>

But:

> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -938,7 +938,47 @@ int qemu_savevm_state_iterate(QEMUFile *f)
>  static bool should_send_vmdesc(void)
>  {
>      MachineState *machine = MACHINE(qdev_get_machine());
> -    return !machine->suppress_vmdesc;
> +    bool in_postcopy = migration_postcopy_phase(migrate_get_current());
> +    return !machine->suppress_vmdesc && !in_postcopy;
> +}

This should be split in its own patch.


		Amit