All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Austin S Hemmelgarn <ahferroin7@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Brown, Len" <len.brown@intel.com>, Len Brown <lenb@kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] suspend: make sync() on suspend-to-RAM optional
Date: Tue, 21 Jul 2015 22:11:28 +0200	[thread overview]
Message-ID: <20150721201128.GA4875@amd> (raw)
In-Reply-To: <55AE66FC.6060509@gmail.com>

Hi!

> >>And I'm not sure what you're talking about here.  Who are the
> >>"affected users" in particular?
> >
> >Who does enter suspend to ram multiple times a second? Only android,
> >AFAICT. Can you run android on mainline kernel? No. Can you run
> >android on kernel with less that 100k lines of patches? No.
> >
> >So who benefits from the new config option? No one.
> You mean aside from the fact that calling sync multiple times during the
> suspend path is wasteful and (potentially) puts unnecessary stress on the
> hardware.  All userspace that I know of calls sync() at least once (and
> sometimes twice) before telling the kernel to enter suspend.  I will
> >>accede

Fix the userland, if that problem bothers you, then.

sync() in userland is racy, sync() after freezer is not supposed to
be.

If you suspend multiple times a second, surely removing extra sync()
calls from your userland is not that much to ask? And actually... do
you know someone who suspends that often an has extra sync? I bet not.

> Also, I'd be willing to bet that FirefoxOS, and whatever Amazon is using on
> their tablets and phones also suspend multiple times a second, and some
> ChromeOS systems might in the near future as well (and ChromeOS is pretty
> darn close to being able to run on mainline).

So can someone from FirefoxOS, Amazon, or ChromeOS present their
requirements?

Because Maemo is in the same league, but got their interfaces right,
and uses low-power CPU modes and runtime power saving to get very nice
results.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2015-07-21 20:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  2:24 [PATCH v4 0/1] suspend: make sync() on suspend-to-RAM optional Len Brown
2015-07-15  2:24 ` [PATCH 1/1] " Len Brown
2015-07-15  6:43   ` Pavel Machek
2015-07-15 14:06     ` Austin S Hemmelgarn
2015-07-15 14:58       ` Brown, Len
2015-07-17 23:54         ` Rafael J. Wysocki
2015-07-21  9:38           ` Pavel Machek
2015-07-21 14:41             ` Rafael J. Wysocki
2015-07-21 15:19               ` Pavel Machek
2015-07-21 15:36                 ` Austin S Hemmelgarn
2015-07-21 20:11                   ` Pavel Machek [this message]
2015-07-21 20:01                 ` Brown, Len
2015-07-21 20:05                   ` Pavel Machek
2015-07-22  1:25                 ` Rafael J. Wysocki
2015-07-22  7:23                   ` Pavel Machek
2015-07-22  8:55                   ` Oliver Neukum
2015-07-31 16:02                     ` Len Brown
2015-07-31 23:56                       ` Rafael J. Wysocki
2015-10-08 15:50                         ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2014-01-23  7:11 Len Brown
2014-01-23  7:29 ` Zhang Rui
2014-01-23  7:41   ` Brown, Len
2014-01-23  7:41     ` Brown, Len
2014-01-23  7:38 ` Srivatsa S. Bhat
2014-01-23  7:59   ` Brown, Len
2014-01-26 21:08 ` Pavel Machek
2015-05-08  6:41   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150721201128.GA4875@amd \
    --to=pavel@ucw.cz \
    --cc=ahferroin7@gmail.com \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.