From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43666)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZIBKq-0003ek-2F
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 03:54:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZIBKm-00040b-Rm
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 03:54:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48470)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1ZIBKm-00040S-Mq
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 03:54:28 -0400
Date: Thu, 23 Jul 2015 12:11:37 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150723064137.GP10280@grmbl.mre>
References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com>
	<1434450415-11339-30-git-send-email-dgilbert@redhat.com>
	<874ml8jj1g.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <874ml8jj1g.fsf@neno.neno>
Subject: Re: [Qemu-devel] [PATCH v7 29/42] Postcopy end in migration_thread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, liang.z.li@intel.com, "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>, qemu-devel@nongnu.org, luis@cs.umu.se, pbonzini@redhat.com, david@gibson.dropbear.id.au

On (Mon) 13 Jul 2015 [15:15:07], Juan Quintela wrote:
> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > The end of migration in postcopy is a bit different since some of
> > the things normally done at the end of migration have already been
> > done on the transition to postcopy.
> >
> > The end of migration code is getting a bit complciated now, so
> > move out into its own function.
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 
> I think that I would splint the function and then add the postcopy code.

Yeah, esp since this code was added / modified in the previous patch.

		Amit