From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56293)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZJmfi-0007OL-8H
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 13:58:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZJmff-0003s6-2U
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 13:58:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41098)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZJmfe-0003rz-Tg
	for qemu-devel@nongnu.org; Mon, 27 Jul 2015 13:58:39 -0400
Date: Mon, 27 Jul 2015 18:58:33 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20150727175833.GD27613@work-vm>
References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com>
	<1434450415-11339-25-git-send-email-dgilbert@redhat.com>
	<20150721104225.GI10280@grmbl.mre>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150721104225.GI10280@grmbl.mre>
Subject: Re: [Qemu-devel] [PATCH v7 24/42] Add
	qemu_savevm_state_complete_postcopy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, pbonzini@redhat.com, david@gibson.dropbear.id.au

* Amit Shah (amit.shah@redhat.com) wrote:
> On (Tue) 16 Jun 2015 [11:26:37], Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > Add qemu_savevm_state_complete_postcopy to complement
> > qemu_savevm_state_complete_precopy together with a new
> > save_live_complete_postcopy method on devices.
> > 
> > The save_live_complete_precopy method is called on
> > all devices during a precopy migration, and all non-postcopy
> > devices during a postcopy migration at the transition.
> > 
> > The save_live_complete_postcopy method is called at
> > the end of postcopy for all postcopiable devices.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
> 
> But:
> 
> > --- a/migration/savevm.c
> > +++ b/migration/savevm.c
> > @@ -938,7 +938,47 @@ int qemu_savevm_state_iterate(QEMUFile *f)
> >  static bool should_send_vmdesc(void)
> >  {
> >      MachineState *machine = MACHINE(qdev_get_machine());
> > -    return !machine->suppress_vmdesc;
> > +    bool in_postcopy = migration_postcopy_phase(migrate_get_current());
> > +    return !machine->suppress_vmdesc && !in_postcopy;
> > +}
> 
> This should be split in its own patch.

Thanks, split.

Dave
> 
> 
> 		Amit
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK