From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJxyS-0005X8-Kx for qemu-devel@nongnu.org; Tue, 28 Jul 2015 02:02:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJxyO-0002lC-Fl for qemu-devel@nongnu.org; Tue, 28 Jul 2015 02:02:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJxyO-0002l5-As for qemu-devel@nongnu.org; Tue, 28 Jul 2015 02:02:44 -0400 Date: Tue, 28 Jul 2015 11:32:32 +0530 From: Amit Shah Message-ID: <20150728060232.GK12267@grmbl.mre> References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com> <1434450415-11339-42-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434450415-11339-42-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, pbonzini@redhat.com, david@gibson.dropbear.id.au On (Tue) 16 Jun 2015 [11:26:54], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Userfault doesn't work with mlock; mlock is designed to nail down pages > so they don't move, userfault is designed to tell you when they're not > there. > > munlock the pages we userfault protect before postcopy. > mlock everything again at the end if mlock is enabled. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: David Gibson Reviewed-by: Amit Shah Amit