From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] RFC: async commands with QMP
Date: Wed, 29 Jul 2015 16:45:34 +0100 [thread overview]
Message-ID: <20150729154534.GJ16847@redhat.com> (raw)
In-Reply-To: <CAJ+F1CLaDHf8Q7cUwo+Q2V0YmXwVaRzx-GB0f6biHTipraec-g@mail.gmail.com>
On Wed, Jul 29, 2015 at 05:32:59PM +0200, Marc-André Lureau wrote:
> Hi Eric
>
> On Wed, Jul 29, 2015 at 5:10 PM, Eric Blake <eblake@redhat.com> wrote:
> > In fact, see commit 65207c59, where we ripped it out with prejudice.
>
> Whoo, I should have looked at git history :)
>
> That implementation looks quite bad indeed (suspending monitor?) And
> it wasn't properly documented it seems. No wonders it wasn't used.
> Btw, apparently it's the reason why "id" is there in the first place.
> I don't think there is a good reason to keep having it in sync
> commands.
Yep, the 'id' is pretty pointless now, but we keep accepting it
and sending it in responses in order to not break compatibility
with any existing apps which might be sending it / checking for
it in responses.
> >> One of the benefits of this is that it means
> >> that libvirt can determine current status of ongoing background jobs
> >> when it restarts and reconnects to a previously launched QEMU, where
> >> as an async command approach is tied to the specific monitor connection
> >> that is open.
> >
> > And that is a real concern with any new proposal for async commands.
>
> I don't think it's incompatible with having async commands, since in
> fact they are already async commands with dummy quick return. Some
> async should be cancelled when the client is gone (this depends on the
> async command, whether it is tight to a client or not). However, no
> old async return should be given to a new client.
Agreed, they're not mutually exclusive. I guess it is more a question
of whether there is a compelling enough reason to support both usage
approaches
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2015-07-29 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 14:49 [Qemu-devel] RFC: async commands with QMP Marc-André Lureau
2015-07-29 14:51 ` Marc-André Lureau
2015-07-29 15:05 ` Daniel P. Berrange
2015-07-29 15:10 ` Eric Blake
2015-07-29 15:32 ` Marc-André Lureau
2015-07-29 15:45 ` Daniel P. Berrange [this message]
2015-07-29 15:18 ` Marc-André Lureau
2015-09-14 13:45 ` Markus Armbruster
2015-09-14 16:01 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729154534.GJ16847@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.