From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964862AbbGaUcQ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 31 Jul 2015 16:32:16 -0400
Received: from casper.infradead.org ([85.118.1.10]:34842 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964841AbbGaUcM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 31 Jul 2015 16:32:12 -0400
Date: Fri, 31 Jul 2015 17:31:25 -0300
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: He Kuang <hekuang@huawei.com>, Li Zefan <lizefan@huawei.com>,
        ast@plumgrid.com, pi3orama@163.com, xiakaixu@huawei.com,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: perf eBPF patch ordering.  was: Re: perf test LLVM was: Re: [GIT
 PULL 00/39] perf tools: filtering events using eBPF programs
Message-ID: <20150731203125.GB16700@kernel.org>
References: <1436445342-1402-1-git-send-email-wangnan0@huawei.com>
 <20150714153657.GL2885@kernel.org>
 <55A63AC4.6040701@huawei.com>
 <20150715112015.GA3868@kernel.org>
 <55A869A1.505@huawei.com>
 <CA+JHD93=ZMFP0gB1NqTXGBjTfSyYC-53Uj7r11gQJnKtQRKcDg@mail.gmail.com>
 <55AE2858.6040409@huawei.com>
 <20150721114151.GF5368@kernel.org>
 <55AF1EA5.5020500@huawei.com>
 <20150731153522.GA16700@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150731153522.GA16700@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Fri, Jul 31, 2015 at 12:35:22PM -0300, Arnaldo Carvalho de Melo escreveu:
> But point here is, when I see "enable passing
> bpf object file to --event" I apply the patch and expect to be able to
> go straight away and do:
 
>     perf record -e foo.o sleep 1
 
> And get some informative message as to hey, yes, I managed to do what
> you asked or something is wrong, but I get:
 
>   [root@felicio ~]# perf record --event foo.o sleep
>   event syntax error: 'foo.o'
>                        \___ parser error
>   Run 'perf list' for a list of valid events
 
>    usage: perf record [<options>] [<command>]
>       or: perf record [<options>] -- <command> [<options>]
 
>       -e, --event <event>   event selector. use 'perf list' to list available events
>   [root@felicio ~]#
 
> So, is it enabled or is it not? Doesn't look like. I.e. I think the best
> thing is to only expose this when it can be used. Till that time, we can

I just tried gdb'ing this with a breakpoint on parse_events_load_bpf(),
but when I run:

  (gdb) b parse_events_load_bpf
  Breakpoint 1 at 0x48b11b: file util/parse-events.c, line 488.
  (gdb) run record -e foo.o sleep 1
  Starting program: /root/bin/perf record -e foo.o sleep 1
  [Thread debugging using libthread_db enabled]
  Using host libthread_db library "/lib64/libthread_db.so.1".
  event syntax error: 'foo.o'
                       \___ parser error
  Run 'perf list' for a list of valid events

Somehow it is not calling what the changeset says it would call when passing
"-e foo.o", investigating...

- Arnaldo