From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932219AbbHCQ5T (ORCPT ); Mon, 3 Aug 2015 12:57:19 -0400 Received: from smtprelay0177.hostedemail.com ([216.40.44.177]:45792 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753262AbbHCQ5P (ORCPT ); Mon, 3 Aug 2015 12:57:15 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1183:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2689:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:5007:6120:6261:7514:7875:8603:10004:10400:10848:10967:11026:11232:11473:11658:11914:12296:12438:12517:12519:12740:13069:13138:13231:13311:13357:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: wool98_4b343031504f X-Filterd-Recvd-Size: 2321 Date: Mon, 3 Aug 2015 12:57:11 -0400 From: Steven Rostedt To: Jungseok Lee Cc: Will Deacon , Mark Rutland , Catalin Marinas , "linux-kernel@vger.kernel.org" , AKASHI Takahiro , "broonie@kernel.org" , "david.griego@linaro.org" , "olof@lixom.net" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC 2/3] arm64: refactor save_stack_trace() Message-ID: <20150803125711.65463359@gandalf.local.home> In-Reply-To: References: <12F47692-3010-4886-B87D-3D7820609177@gmail.com> <20150716113115.45a17f17@gandalf.local.home> <20150716121658.7982fdf5@gandalf.local.home> <20150717124054.GE26091@leverpostej> <20150717090009.720f6bd0@gandalf.local.home> <77EA0F10-D5F6-48BD-8652-3B979A978659@gmail.com> <20150717104144.6588b2f7@gandalf.local.home> <0886A996-40E1-49E9-823C-85E55A858716@gmail.com> <1357EA74-B972-4B99-ADB0-BC7E8F06DDB5@gmail.com> <20150720162004.GL9908@arm.com> <20150803090951.GA10501@arm.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Aug 2015 01:30:50 +0900 Jungseok Lee wrote: > There are two issues in the current version. > 1) The change does not work correctly when function_graph feature is enabled. > 2) Akashi have raised an issue that size field of stack tracer is inaccurate. > > So, I think this patch set is not ready yet. Do you still want me to add code that does: if (*p == (stack_dump_trace[i] + FTRACE_STACK_FRAME_OFFSET)) { ? If you expect to need that, I can get it into the next merge window and you can base the code of that in the merge window after that. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt@goodmis.org (Steven Rostedt) Date: Mon, 3 Aug 2015 12:57:11 -0400 Subject: [RFC 2/3] arm64: refactor save_stack_trace() In-Reply-To: References: <12F47692-3010-4886-B87D-3D7820609177@gmail.com> <20150716113115.45a17f17@gandalf.local.home> <20150716121658.7982fdf5@gandalf.local.home> <20150717124054.GE26091@leverpostej> <20150717090009.720f6bd0@gandalf.local.home> <77EA0F10-D5F6-48BD-8652-3B979A978659@gmail.com> <20150717104144.6588b2f7@gandalf.local.home> <0886A996-40E1-49E9-823C-85E55A858716@gmail.com> <1357EA74-B972-4B99-ADB0-BC7E8F06DDB5@gmail.com> <20150720162004.GL9908@arm.com> <20150803090951.GA10501@arm.com> Message-ID: <20150803125711.65463359@gandalf.local.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 4 Aug 2015 01:30:50 +0900 Jungseok Lee wrote: > There are two issues in the current version. > 1) The change does not work correctly when function_graph feature is enabled. > 2) Akashi have raised an issue that size field of stack tracer is inaccurate. > > So, I think this patch set is not ready yet. Do you still want me to add code that does: if (*p == (stack_dump_trace[i] + FTRACE_STACK_FRAME_OFFSET)) { ? If you expect to need that, I can get it into the next merge window and you can base the code of that in the merge window after that. -- Steve