From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbbHDP4I (ORCPT ); Tue, 4 Aug 2015 11:56:08 -0400 Received: from mail.kernel.org ([198.145.29.136]:47576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbbHDP4F (ORCPT ); Tue, 4 Aug 2015 11:56:05 -0400 Date: Tue, 4 Aug 2015 12:55:57 -0300 From: Arnaldo Carvalho de Melo To: "Wangnan (F)" Cc: pi3orama , He Kuang , Li Zefan , Alexei Starovoitov , Xia Kaixu , linux-kernel@vger.kernel.org, Ingo Molnar , Jiri Olsa , David Ahern , Namhyung Kim Subject: Re: perf eBPF patch ordering. was: Re: perf test LLVM was: Re: [GIT PULL 00/39] perf tools: filtering events using eBPF programs Message-ID: <20150804155557.GB3126@kernel.org> References: <20150731153522.GA16700@kernel.org> <20150731203125.GB16700@kernel.org> <55BED407.9090009@huawei.com> <20150803150728.GA3864@kernel.org> <20150803151905.GE3864@kernel.org> <20150803161116.GB5498@kernel.org> <20150803194917.GE5498@kernel.org> <55C04D60.2050101@huawei.com> <55C0966B.5020801@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55C0966B.5020801@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Aug 04, 2015 at 06:39:39PM +0800, Wangnan (F) escreveu: > Just realized that 'tempnam' is not safe. Switch to mkdtemp. Please see the > new version: > > https://github.com/WangNan0/linux/commit/bd02aed760c4a35fec4483d24c158799f05f6f9e > > and pull request update: > > The following changes since commit 922cc21746202956acb41c89a6190bb50805fa31: > > perf tools: Introduce llvm config options (2015-07-31 12:17:50 -0300) > > are available in the git repository at: > > https://github.com/WangNan0/linux.git ebpf Ok, but I am checking patch by patch to see if the changes I made are kept, and for the first one, it wasn't (the second one is the cset in your newest github tree: cceb9fed5722dc78730e7ed739b75ece4476740f, the other is for my tree, that was rebased, but the contents should be the same as what is in my perf/ebpf branch in git.kernel.org), I'm keeping my version, will check the others: [acme@felicio linux]$ gdiff f696ecb01b519ae8273b2876b45678b920767f8a cceb9fed5722dc78730e7ed739b75ece4476740f --- /tmp/gdiff.f696ecb01b519ae8273b2876b45678b920767f8a.y3ojwYFV0g 2015-08-04 12:53:29.898525129 -0300 +++ /tmp/gdiff.cceb9fed5722dc78730e7ed739b75ece4476740f.1ximzKA8ST 2015-08-04 12:53:29.900525095 -0300 @@ -1,4 +1,4 @@ -commit f696ecb01b519ae8273b2876b45678b920767f8a +commit cceb9fed5722dc78730e7ed739b75ece4476740f Author: Wang Nan Date: Thu Jun 11 10:31:09 2015 +0000 @@ -14,20 +14,8 @@ source code path is injected into shell command using environment variable using force_set_env(). - Commiter notice: - - When building with DEBUG=1 we get a compiler error that gets fixed with - the same approach described in commit b236512280fb: - - perf kmem: Fix compiler warning about may be accessing uninitialized variable - - The last argument to strtok_r doesn't need to be initialized, its - just a placeholder to make this routine reentrant, but gcc doesn't know - about that and complains, breaking the build, fix it by setting it to - NULL. - Signed-off-by: Wang Nan - Acked-by: Alexei Starovoitov + Cc: Alexei Starovoitov Cc: Brendan Gregg Cc: Daniel Borkmann Cc: David Ahern @@ -43,7 +32,7 @@ Signed-off-by: Arnaldo Carvalho de Melo diff --git a/tools/perf/util/llvm-utils.c b/tools/perf/util/llvm-utils.c -index 472e8cd69361..7d01fcc23aa8 100644 +index 472e8cd69361..08e2eb1354e3 100644 --- a/tools/perf/util/llvm-utils.c +++ b/tools/perf/util/llvm-utils.c @@ -43,3 +43,228 @@ int perf_llvm_config(const char *var, const char *value) @@ -55,7 +44,7 @@ +search_program(const char *def, const char *name, + char *output) +{ -+ char *env, *path, *tmp = NULL; ++ char *env, *path, *tmp; + char buf[PATH_MAX]; + int ret; +