From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755584AbbHFRyE (ORCPT ); Thu, 6 Aug 2015 13:54:04 -0400 Received: from foss.arm.com ([217.140.101.70]:39656 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754499AbbHFRyD (ORCPT ); Thu, 6 Aug 2015 13:54:03 -0400 Date: Thu, 6 Aug 2015 10:52:47 -0700 From: Drew Richardson To: Nicolas Pitre Cc: "linux@arm.linux.org.uk" , Dave P Martin , "christoffer.dall@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Wade Cherry , Pawel Moll Subject: Re: [PATCH] ARM: Mark ret_fast_syscall as a function Message-ID: <20150806175246.GA13323@dreric01-gentoo.localdomain> References: <1436877957-18127-1-git-send-email-drew.richardson@arm.com> <20150806170758.GA26691@dreric01-gentoo.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 06, 2015 at 06:30:40PM +0100, Nicolas Pitre wrote: > On Thu, 6 Aug 2015, Drew Richardson wrote: > > > On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote: > > > ret_fast_syscall runs when user space makes a syscall. However it > > > needs to be marked as such so the ELF information is correct. Before > > > it was: > > > > > > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall > > > > > > But with this change it correctly shows as: > > > > > > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall > > > > > > I see this function when using perf to unwind call stacks from kernel > > > space to user space. Without this change I would need to add some > > > special case logic when using the vmlinux ELF information. > > > > > > Signed-off-by: Drew Richardson > > > > I haven't heard any further comments on this, did this get merged and > > I just didn't notice? Or did I forget to add someone? > > Most likely that it is so trivial that nobody paid much attention. > > FWIW, you can add > > Acked-by: Nicolas Pitre > > and submit it here: http://www.arm.linux.org.uk/developer/patches/ > > > Nicolas > Done, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: drew.richardson@arm.com (Drew Richardson) Date: Thu, 6 Aug 2015 10:52:47 -0700 Subject: [PATCH] ARM: Mark ret_fast_syscall as a function In-Reply-To: References: <1436877957-18127-1-git-send-email-drew.richardson@arm.com> <20150806170758.GA26691@dreric01-gentoo.localdomain> Message-ID: <20150806175246.GA13323@dreric01-gentoo.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Aug 06, 2015 at 06:30:40PM +0100, Nicolas Pitre wrote: > On Thu, 6 Aug 2015, Drew Richardson wrote: > > > On Tue, Jul 14, 2015 at 01:45:57PM +0100, Drew Richardson wrote: > > > ret_fast_syscall runs when user space makes a syscall. However it > > > needs to be marked as such so the ELF information is correct. Before > > > it was: > > > > > > 101: 8000f300 0 NOTYPE LOCAL DEFAULT 2 ret_fast_syscall > > > > > > But with this change it correctly shows as: > > > > > > 101: 8000f300 96 FUNC LOCAL DEFAULT 2 ret_fast_syscall > > > > > > I see this function when using perf to unwind call stacks from kernel > > > space to user space. Without this change I would need to add some > > > special case logic when using the vmlinux ELF information. > > > > > > Signed-off-by: Drew Richardson > > > > I haven't heard any further comments on this, did this get merged and > > I just didn't notice? Or did I forget to add someone? > > Most likely that it is so trivial that nobody paid much attention. > > FWIW, you can add > > Acked-by: Nicolas Pitre > > and submit it here: http://www.arm.linux.org.uk/developer/patches/ > > > Nicolas > Done, thanks.