From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 02/18] drm/cma-helper: Fix locking in drm_fb_cma_debugfs_show Date: Mon, 10 Aug 2015 12:41:02 +0200 Message-ID: <20150810104101.GB1262@ulmo.nvidia.com> References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch> <1436477570-4936-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1478683924==" Return-path: In-Reply-To: <1436477570-4936-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Laurent Pinchart , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1478683924== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DBIVS5p969aUjpLe" Content-Disposition: inline --DBIVS5p969aUjpLe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 09, 2015 at 11:32:34PM +0200, Daniel Vetter wrote: > This function takes two locks, both of them the wrong ones. This > wasn't an oversight from my fb locking rework since both patches > landed in parallel. We really only need fb_lock when walking that > list, since everything we can reach from that is refcounted properly > already. >=20 > Cc: Rob Clark > Cc: Laurent Pinchart > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 16 ++-------------- > drivers/gpu/drm/drm_gem_cma_helper.c | 2 -- > 2 files changed, 2 insertions(+), 16 deletions(-) Reviewed-by: Thierry Reding --DBIVS5p969aUjpLe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyH+6AAoJEN0jrNd/PrOh704P/2xQNcU3ZXl4m4xSjv7i6Uh4 rIXRf5bnSfluWI5+Q2S76G2nEA9sxoAvG8NB+NRAaeDP2TGSAypjz1Ux4S2FeagK 7SnLcECkMo9NPGh2/NnwYC3A6xjJSTEfyzqZaUawPS/krxukCrrXzjZgGxVlow0H 3/U2odPKwm9uGsx44hcpQt/l4M5WhYEXDUy0wP7kdRYIes5kTKiZ483OC3dGRCOd nnPyplTTbTMGvYuCMGQr0pijGDQYNqDWmHYaNKrok7lwg9WS5lRoVZh7HqqqoF1B JV9acSlhLXAviVFkaZpFIHL6OfXxVjCjDTX7838llA5XueQHKn+LK6sSvsw3Hns9 7EMVwuKR7iTKC6y6idRSYzCID0qJirH+5z483KXVJSYCmUq+hQo/LW+Z/fpjtuJI aEqGXqybI9aGBEaIZc7q8mgWWKtd/wTXEja1u7t4TLLcZ08Ds3vGVdVzlYpO/P2G JHi+HiqC7KB7DWz5h5WSX+OMW3mxWtYEHi2Kh8OpD2v76gfjuSLWiphwurnKL+o1 vK8Yom3oZYNMy0ZoXhzQdE1Oh29lfPVmM8xNolWDpgC3jUSU+rjl8dY6VdR+Vb3x UtB9XOdNQCNaP5nWGJ3VP/5C4Bardhupjho2VUIhDdhRvRsdc7gWSCGB+GlccrLM nJO1ZXbI74fTSFly35GE =Mwnn -----END PGP SIGNATURE----- --DBIVS5p969aUjpLe-- --===============1478683924== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1478683924==--