From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 05/18] drm/bochs: Don't grab dev->struct_mutex for in mmap offset ioctl Date: Mon, 10 Aug 2015 12:45:55 +0200 Message-ID: <20150810104554.GD1262@ulmo.nvidia.com> References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch> <1436477570-4936-6-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0740741211==" Return-path: In-Reply-To: <1436477570-4936-6-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0740741211== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bjuZg6miEcdLYP6q" Content-Disposition: inline --bjuZg6miEcdLYP6q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 09, 2015 at 11:32:37PM +0200, Daniel Vetter wrote: > Since David Herrmann's mmap vma manager rework we don't need to grab > dev->struct_mutex any more to prevent races when looking up the mmap > offset. Drop it and instead don't forget to use the unref_unlocked > variant (since the drm core still cares). >=20 > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/bochs/bochs_mm.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Thierry Reding --bjuZg6miEcdLYP6q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyIDiAAoJEN0jrNd/PrOh0K0P+wd5V2Oc307rU4SEB+BDR2PD QFQ+uA1koJhZNNXPq46B1T3Ov40mFbEOR2LMuez64P6nSEiype4mrZ6Ne0P1gImh SV7pulPUK82EWaKVyX129ctajI4UHwb00gMAP3miDpetQvKpeziaXK8ojucgSv9P 6QS9oh5EZEiIMaIWmcsn77O22gd8O9EzyKy3ihq4ylS22+pwXcaylT21MeBcyVVU IJkf1VzD+sp+Y5iy70kv7HqNjQVl3a0Bi9+Ci/QgK6CKQcsPooTQEa2X0vyUgoaE Z9avT6sYAKk3MR6JUhTBlEnlwweNrJFNfSqbWtYPiZP97VY1pmXcS6R8JlSV2N3C qJcL3u/yMQ5t0/yYIjjiamKMrdzHfz/2nvMKtFTNM39TpiEKbIWEoY4chw+kS6+2 CUtutUdjQCrbQh5LoSqIPyZA/pee6rzi3WSJ+adZa0Q447gBoGz8ePxo2gP1rZju tNcQxE0Xr6wycphEmfJyB/5u0RMRdNkpM1Amm+cBFlSC0JFHzurJE9KnzcpHOvac eRAjsuZj+iioFWskTGwFwBKskP0gKd77yvRRS5+uzp/y0EXsB7Q4W1KN97q2jKqb T1FYFYd/uLfoR/b1qt6ehBvtO4LyTx5FdIff/bfkQcK5fFsXhi8K/q265HmIlSsR bfdM+R3PncA4HSV3SJak =U8wZ -----END PGP SIGNATURE----- --bjuZg6miEcdLYP6q-- --===============0740741211== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0740741211==--