From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 04/18] drm/ast: Don't grab dev->struct_mutex for in mmap offset ioctl Date: Mon, 10 Aug 2015 12:46:11 +0200 Message-ID: <20150810104609.GE1262@ulmo.nvidia.com> References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch> <1436477570-4936-5-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0486470014==" Return-path: In-Reply-To: <1436477570-4936-5-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0486470014== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KuLpqunXa7jZSBt+" Content-Disposition: inline --KuLpqunXa7jZSBt+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 09, 2015 at 11:32:36PM +0200, Daniel Vetter wrote: > Since David Herrmann's mmap vma manager rework we don't need to grab > dev->struct_mutex any more to prevent races when looking up the mmap > offset. Drop it and instead don't forget to use the unref_unlocked > variant (since the drm core still cares). >=20 > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/ast/ast_main.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) Reviewed-by: Thierry Reding --KuLpqunXa7jZSBt+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyIDxAAoJEN0jrNd/PrOhl+wP/2zkIvVEdv4LjICIp4ENOox8 O2yvxTvdRSp5ifCpjBOI2NIvXJyXkvbaEIUOF3bbHRMUB/7eLS7gZ2SPxK9Vjoeg 7nCKPw+uZV90YHxgv68z5/AsGohRDj02DzRCEHg5jAmMwXeT7uSw/QES8dOc7qAO 70DqZa6Sphh5oAtDZg5WS7O16zQR+myrJ0Kf1MrkScRkyJUyVNmZEiGxx5iKvqZA WtHTNzeGzM/0ein5wJgCYaKQpBcUYP0mohP9E2th99SHKyPuebAbn7Kj4V/PtiRE b/vH1ejLcmHKfQXxFzCq0sfw9cXd9h3U1ek6BUkpHXgjzs0cXAxsD2f1lvMBbeWC q7Jeu8IFy136GCk/6XIQzfK7el8CElsXQXHxHYBhBZ8oTO+bfbdv+OCb68Djnuwb dV2qE/0nuEeOJXZ2clJk0K//Eq3HIr07qU6fP3LEAi8ypLkweOWVLDkzGEDueNdN UvhAn4xw8QiKdJYAGc+/G35wIJSDulMF5efYMKW8Q0J3rdhdZ2BVGrVK+StLHrzI lvjP4dFksCzYRWEPzcc30P/DOM7QpqU58/x8HiudhQFFWUAydvvr5WBwVgz/J9Et 1zVT3AC0giUefi2EHok8z4FChKKjuU2ZEFM6Epk/GthqMiizuTWq38zBL+sxNNcz 1Er70nr6huF3MfDb/Fav =w0eR -----END PGP SIGNATURE----- --KuLpqunXa7jZSBt+-- --===============0486470014== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0486470014==--