From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 06/18] drm/mga200g: Don't grab dev->struct_mutex for in mmap offset ioctl Date: Mon, 10 Aug 2015 12:46:29 +0200 Message-ID: <20150810104628.GF1262@ulmo.nvidia.com> References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch> <1436477570-4936-7-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0153697423==" Return-path: In-Reply-To: <1436477570-4936-7-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0153697423== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NGIwU0kFl1Z1A3An" Content-Disposition: inline --NGIwU0kFl1Z1A3An Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 09, 2015 at 11:32:38PM +0200, Daniel Vetter wrote: > Since David Herrmann's mmap vma manager rework we don't need to grab > dev->struct_mutex any more to prevent races when looking up the mmap > offset. Drop it and instead don't forget to use the unref_unlocked > variant (since the drm core still cares). >=20 > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/mgag200/mgag200_main.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Thierry Reding --NGIwU0kFl1Z1A3An Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyIEEAAoJEN0jrNd/PrOhp7QP/3jpd+1l5zcVz7LvozkIONUx xFnMVJ1p20Hls7Kd34STt6DCeb3aXopcQwEbhDt+e259P5ArKy/hQ+hFxaxhwsWb Sz2v7unE9QGmKq6hyoYLY/BQYVbkckpFUzPPBahe931MjVzXePQWEuM5eADBfHw8 +8k0uvMsLjKdzSrOEhWusMKJJI7K+pIHJtDD9Vpm1U4t+pJmxOq703rFoEtQpJbJ POLUIK9k0GKbRqHvv42TDAA4XjQHzJEPsU6z+Kn5pUHCbY+IC2/KlhP8PadThtX7 zeATCIF9BaVAbZq2H8upyKdxoRNS4vB9uTpp1qostfw0wGp9ceQ/TywWvrOWHa5S rsePChcTVt4nCAlWBz/jJLuL8sEwDirbvgDv9PasLiREkbuDdmQzK65YcKN+Ftp/ qrp4orRD/ang6uNsiZpzHArYM3oSvLOybu7W+/NKH1oTn0SSxUU3cT3cGkWysi0a lgBJ+O2xFWdHmAB0I0tRVgwhtfrAED2eY3Y2eU4LAYaDxDwEX0KOM0gNKgrhIDF8 0LynN2uNM8DM5FeWN7/izK1ahqHhMXIJChJJhNK78kQVmwtBs1yHz4UFzsYcnv3V 5UVSpDUqCEB2pywAZEQidEw/QlLFmevPzwetQXZaQyAE9RGOrBxZJ4CGucmsB/vN NlXIgSP7/t3nyWLLlhEQ =Wl0M -----END PGP SIGNATURE----- --NGIwU0kFl1Z1A3An-- --===============0153697423== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0153697423==--