From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 08/18] drm/cirrus: Don't grab dev->struct_mutex for in mmap offset ioctl Date: Mon, 10 Aug 2015 12:53:58 +0200 Message-ID: <20150810105357.GI1262@ulmo.nvidia.com> References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch> <1436477570-4936-9-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1362699604==" Return-path: In-Reply-To: <1436477570-4936-9-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1362699604== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6lCXDTVICvIQMz0h" Content-Disposition: inline --6lCXDTVICvIQMz0h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 09, 2015 at 11:32:40PM +0200, Daniel Vetter wrote: > Since David Herrmann's mmap vma manager rework we don't need to grab > dev->struct_mutex any more to prevent races when looking up the mmap > offset. Drop it and instead don't forget to use the unref_unlocked > variant (since the drm core still cares). >=20 > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/cirrus/cirrus_main.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) Reviewed-by: Thierry Reding --6lCXDTVICvIQMz0h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyILFAAoJEN0jrNd/PrOhkT8QAI27p0cEvPNMjX1d3YrtfJ4v KZEMey24I+lOon1e0NK2JrIlP9fX+qzFbMwSjb5MR/F1aEGwe1opSKLAUczyPOYZ DxeGuFF6xpf3JEGGVezm/y38ARNArduS910xPySfZd5ZAc+UxuuS/j975NAjM6wQ kCimcWWAdDmGrGIkUkVFJkW27jEhlgWAVd1z0QTRhxejGWlNEsMVEpos3OXazL5z QOFzthSJ+YRrKTi/87cK6bso21CeHkA9tS23R2hx2llP4edf59eC+CxEqPSPrdVU GXv8PO5pnPXCi2XwCAK8GQ26QroAFTFGQ3QS82ZqmQcJIDgaTnh9u0Q4khsxIK6L kg2VRvYAiRBbTQY0EwkuV0aVaq4rWbarHDfvhbsyZUBMZDOe7WXCH5fiksUb0nqQ BspXfFUPVEw4oUDpejCxS1FxOojg854Cy7KtybSx0Roug9Rac9ZW+MptcZrXosWS a+OFL4LlOFZ5ErAicJ/oXdizyUQOz41Hh+vngcS2kcpQVK7cK8mpAtNKQWf88/1m XdAbyJJkFZWUEyXbKMx7cYNRYwxJgl35XwxeQrGx1j+wBQCxYSQ7kl0op9KbSJ2R 1S7fsrjdpRPk7wKZ7liVDyzzUpaaDIw36JtEyBeWwm0BJGn3G9x3I6sDgQZfLjGL bhwNy+k3byk1YGI3mtkY =VkZY -----END PGP SIGNATURE----- --6lCXDTVICvIQMz0h-- --===============1362699604== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1362699604==--