From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 09/18] drm/cma-helper: Don't grab dev->struct_mutex for in mmap offset ioctl Date: Mon, 10 Aug 2015 12:54:19 +0200 Message-ID: <20150810105417.GJ1262@ulmo.nvidia.com> References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch> <1436477570-4936-10-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1346719333==" Return-path: In-Reply-To: <1436477570-4936-10-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Laurent Pinchart , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1346719333== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ublo+h3cBgJ33ahC" Content-Disposition: inline --Ublo+h3cBgJ33ahC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 09, 2015 at 11:32:41PM +0200, Daniel Vetter wrote: > Since David Herrmann's mmap vma manager rework we don't need to grab > dev->struct_mutex any more to prevent races when looking up the mmap > offset. Drop it and instead don't forget to use the unref_unlocked > variant (since the drm core still cares). >=20 > Cc: Laurent Pinchart > Cc: Rob Clark > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_gem_cma_helper.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Thierry Reding --Ublo+h3cBgJ33ahC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyILZAAoJEN0jrNd/PrOh7lgP/REpvpHBffOkwDMWF2UIkvO5 QVHHMgw/E2hxpfvVMmoVkOs4T97yV183JSYrAyYj2dbGeapkPXF3m8Z4FbesJ+OU 0oPBbLKk7mlDxJ6Nvrww6VU1Yx+BQIxX2YVYzgl8HRMz2kh1iAIxPZC3n1MFJI2T KU5flMStvv+dpe0eow2jZaUvDes4f9xXVq1niM/kJTJhnfNjTSovRq0YA0RMcDrE TcS8L4cnQ3n3HDykqJ/PFbfk7YJ1ZeISoiNDRaqpGPXIVBNV7q9jRo7UKw2udWek 3y5wuaz0CHIyG5C7hdoZRFlm9AoOJiYU23c+uYE8yc2ZsI+ZmfKurRJvpvR0GFYp VuqUQUB2fpDcMMZuAL4p/HEZtYNS6RqNo9NbYrT2+zybEBHL6KFLE7vQPD2q+jJu WBWuz70yXbWL1igK8BP8ShNz/Fj2n5y14t4uwY7gEKkVIuZPUTyL/ByYidvmHXi3 1k1hUMlx3ew6PUOrYDvdgi12dmIprYj4QhlRNqoAb5b29OiZIVJWPT1eFTk7MpGe tT4LoNaVKMgcM3Ng0imDJiF3RjKmUqOIRBmV2bNNcPGFaSIseNettJldmmgYjYkR rjn1HuNRT16lHMYrroosvdZYvByCiaPHf2JhVekN0MDnvh6E/YziANYK6dmNkKa3 TBU2RXHnpemomfNU8zI+ =odSS -----END PGP SIGNATURE----- --Ublo+h3cBgJ33ahC-- --===============1346719333== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1346719333==--