From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 11/18] drm/armada: Don't grab
 dev->struct_mutex for in mmap offset ioctl
Date: Mon, 10 Aug 2015 12:59:09 +0200
Message-ID: <20150810105908.GL1262@ulmo.nvidia.com>
References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch>
 <1436477570-4936-12-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1858679472=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <1436477570-4936-12-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>, Russell King <rmk+kernel@arm.linux.org.uk>
List-Id: dri-devel@lists.freedesktop.org


--===============1858679472==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="QWRRbczYj8mXuejp"
Content-Disposition: inline


--QWRRbczYj8mXuejp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 09, 2015 at 11:32:43PM +0200, Daniel Vetter wrote:
> Since David Herrmann's mmap vma manager rework we don't need to grab
> dev->struct_mutex any more to prevent races when looking up the mmap
> offset. Drop it and instead don't forget to use the unref_unlocked
> variant (since the drm core still cares).
>=20
> While at it also fix a leak when this ioctl is called on an imported
> buffer.
>=20
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/armada/armada_gem.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

--QWRRbczYj8mXuejp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJVyIP7AAoJEN0jrNd/PrOhpIkQAJSpCiXhcFooDWZKHdvFvEgA
EFBsprZr7FLtQNcotDTmmhaworiV7LnCieEnGz8q+p7Hj+oztW29lmxhKRRUBxin
f1pbh6yz8Y/O+5U9EHItm6wx3m09JsdswnyikDAQyEtZK5vL4KbojywLalHs91AN
oG4EZKdKcbYKGi50rGLLPuKWZRJ7xMyCQou9zT1c9YksCuWihMvXg1lLduU0IpBX
6gBE4dYdS4KMKOZh+JCnYUWtckHVNoFBara0hrEvWsMIuzeFd1ck84GyS2ZkmH9k
aB9W9x2wbuqQR+N8IOjPNfCBYjTe5AgQzF59BYMmIA4i8L2uwml1nz3bLGQWhs5r
6fzWNzbUtalIVDXdZq9TDVi5yVeg/hSLdgNysiPaIXeJnTfF985i9QU81dbGC2B3
03lqhvA6PAzmapYvMSYymOMRKgHT7bQGupQ5VoQeqEaex4EDuEFSCDE1x07Mvq5W
Y9MCUuoKGoVfLe8JLSyZolfRhER3t1w0UzZkpV3XBEFODaXjlQJF1ZDFfHC0yOgF
kez5NAnJ9vW95WL7lQ9J8BYrf6sZj3Mj2g0QR5oRzfxACk+L7APgxrqwRQPzx37a
ircIr2i2+LqPcedepNmryeld0TKscLsBr+QmLPKWyeKJmyu6h0p+hl3wXwz2+cUz
giFzIKbJGNi6JeOxxZa9
=QuAy
-----END PGP SIGNATURE-----

--QWRRbczYj8mXuejp--

--===============1858679472==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK

--===============1858679472==--