From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 12/18] drm/nouveau: Don't take dev->struct_mutex in fbcon init Date: Mon, 10 Aug 2015 12:59:25 +0200 Message-ID: <20150810105923.GM1262@ulmo.nvidia.com> References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch> <1436477570-4936-13-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0772802667==" Return-path: In-Reply-To: <1436477570-4936-13-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Ben Skeggs , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0772802667== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fDP66DSfTvWAYVew" Content-Disposition: inline --fDP66DSfTvWAYVew Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 09, 2015 at 11:32:44PM +0200, Daniel Vetter wrote: > It doesn't protect anything at all. fbdev helper state is all > protected by modeset locks, and nouveau bo state is taken care of by > ttm. There's also nothing else grabbing struct_mutex that might need > to coordinate with this code. Also this is driver load code, no one > can get at the device yet anyway so locking is fairly futile. > There's also no drm_gem_object_unreference that would now suddenly > need the _unlocked variant. >=20 > Cc: Ben Skeggs > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Thierry Reding --fDP66DSfTvWAYVew Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyIQLAAoJEN0jrNd/PrOhDngQAKA4zeLFhYtzI5aV1Ct+QgnW wrH6xJjKOkq0qh4wLUUvBB0MyzeIGZZWkQzYPwr63KJJzOBsPLzeaAwga/eoR9WG WHCy6qUKiyX2y6cZGU7ADoYDksfiCOtFaVpPfrvhxW/HfApBB8zZuZDFHUDDPvhk /UfbZOHJCISjzAw05+XP76aB1PsTBtBRlodz6F4/Vpg1LnXIxiO7ibSF77AHn96Q O+BZMr/exEOx0sPvl4JjYIJvCPSYE81eahselIHLlyNo9/JPRlD13tay3n/bh4Wb sbOHk1ZP/cIjYuDkpyKOcmJBwREXQPvrzcE6kzN6QG+lpbcIPR/SE9h0SWvoDbfR iETW0iLV7u+SHgvki1p5LyCH5SPJNpiNRIAhEjzy3XoO6QlQN8kKD+RvlRiOT3B/ vb2uo2NO21Tk3C4vBPNPYjib8Ye7L7LBi2H2rVeFwV5y4ORI4/dZgqlELwG4uzjx pE4k6vpZWOQSfMjBfKfH7kD48ALt2npLYBD8TVnogk3ZXFViiEr2Fagn2RXtw4K2 PPSIS+0M0Qr2sa/zo3GdLln6cx4S/CIUT2/O7WS+u4UDKXcG8Nqo4DvIAFvE3GyM ukJXYrm+qn6wrOeQP0abLF9fIYGkkQ9sss7vFsXbvdeHOgcKO0aoEvztPwaw5UH9 IFyaSjhOBDLoZnQZHY70 =Iarl -----END PGP SIGNATURE----- --fDP66DSfTvWAYVew-- --===============0772802667== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0772802667==--