From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 18/18] drm/amdgpu: don't grab dev->struct_mutex in pm
 functions
Date: Mon, 10 Aug 2015 13:00:57 +0200
Message-ID: <20150810110056.GR1262@ulmo.nvidia.com>
References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch>
 <1436477570-4936-19-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1413110442=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <1436477570-4936-19-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Alex Deucher <alexander.deucher@amd.com>, Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Christian =?utf-8?B?S8O2bmln?= <christian.koenig@amd.com>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org


--===============1413110442==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="X35wERi4JU/f1kly"
Content-Disposition: inline


--X35wERi4JU/f1kly
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 09, 2015 at 11:32:50PM +0200, Daniel Vetter wrote:
> Similar to radeon, except that amdgpu doesn't even use struct_mutex to
> protect anything like the shared z buffer (sane gpu architecture,
> yay!). And the code already grabs the globa adev->ring_lock, so this
> code can't race with itself. Which makes struct_mutex completely
> redundnant. Remove it.
>=20
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

--X35wERi4JU/f1kly
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJVyIRoAAoJEN0jrNd/PrOhT4EP/i+UmNFVIXIzezmsUeVN7D1B
TldLJn5kVZgc0GU0dI98fBBFgrquA4yHcb45wtgywvu+U/wLOIQXBmyYxPy4aRn5
8WDaKtMITFIAhufDmwu7s5gc51FrdV1aEvso3KxcBF9MPYiJPYoo+1QmxoW1qczM
Cf+E83qm3u3i41iG8hBDtgMgG3iNxDINYXqRgGCZL+eRolLwbgSICJho1SWG8Y+/
VBkCSj2i0NKwibBPwCowitQplS3b4bGroXE8VQaWOekjwoAlvV/HfHjptSZR9H4w
+Uuz+76MhmiJO5ig71G+DlppncvcBoaK1d8canevqYX0rjw5Q7P/NLvBski030dS
M1swtP+/KAs/YiNKRPdL8iR9GpoPUk5/QjBURoffo4jYKCHPda9L1MnCwv+X6rcn
orpfiWJcG0c06V5hkGnHKCafY2XNBlCll75mgG4zHoJvLnDslw1/6nm3UrXqJpVz
2qUhVUK9FLBM6wuIBOxHRP2mC/KsXM1Vt6yApEBUeCUcX1xQGy5BG3/Xl81/i2/V
THH/gPRqQ/WazWRYmBWhHw1ytfDW8MFFDHfwqWOsnZCvIWPebGgeV9sCZf7n9y6n
Ne2WY/o7TlgT44wS2fRM/SmNXgrEYHq3TXgIW9syhR1maFmkdIecToJ0vK93GJhQ
JRefQNmrGDOiTzzCaDtV
=l4OL
-----END PGP SIGNATURE-----

--X35wERi4JU/f1kly--

--===============1413110442==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

--===============1413110442==--