From: Wei Liu <wei.liu2@citrix.com>
To: Chunyan Liu <cyliu@suse.com>
Cc: jgross@suse.com, wei.liu2@citrix.com, ian.campbell@citrix.com,
george.dunlap@eu.citrix.com, Ian.Jackson@eu.citrix.com,
xen-devel@lists.xen.org, jfehlig@suse.com,
Simon Cao <caobosimon@gmail.com>
Subject: Re: [PATCH V6 7/7] domcreate: support pvusb in configuration file
Date: Tue, 11 Aug 2015 12:27:05 +0100 [thread overview]
Message-ID: <20150811112705.GG7460@zion.uk.xensource.com> (raw)
In-Reply-To: <1439202928-24813-8-git-send-email-cyliu@suse.com>
On Mon, Aug 10, 2015 at 06:35:28PM +0800, Chunyan Liu wrote:
> Add code to support pvusb in domain config file. One could specify
> usbctrl and usb in domain's configuration file and create domain,
> then usb controllers will be created and usb device would be attached
> to guest automatically.
>
> One could specify usb controllers and usb devices in config file
> like this:
> usbctrl=['version=2,ports=4', 'version=1, ports=4', ]
> usbdev=['2.1,controller=0,port=1', ]
>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> Signed-off-by: Simon Cao <caobosimon@gmail.com>
> ---
[...]
> }
>
> + if (!xlu_cfg_get_list(config, "usbctrl", &usbctrls, 0, 0)) {
> + d_config->num_usbctrls = 0;
> + d_config->usbctrls = NULL;
> + while ((buf = xlu_cfg_get_listitem(usbctrls, d_config->num_usbctrls))
> + != NULL) {
> + libxl_device_usbctrl *usbctrl;
> +
> + d_config->usbctrls =
> + (libxl_device_usbctrl *)realloc(d_config->usbctrls,
> + sizeof(libxl_device_usbctrl) * (d_config->num_usbctrls + 1));
> + usbctrl = d_config->usbctrls + d_config->num_usbctrls;
> + libxl_device_usbctrl_init(usbctrl);
> +
Use ARRAY_EXTEND_INIT macro.
> + parse_usbctrl_config(usbctrl, buf);
> +
> + d_config->num_usbctrls++;
> + }
> + }
> +
> + if (!xlu_cfg_get_list(config, "usbdev", &usbs, 0, 0)) {
> + d_config->num_usbs = 0;
> + d_config->usbs = NULL;
> + while ((buf = xlu_cfg_get_listitem(usbs, d_config->num_usbs)) != NULL) {
> + libxl_device_usb *usb;
> +
> + d_config->usbs = (libxl_device_usb *)realloc(d_config->usbs,
> + sizeof(libxl_device_usb) * (d_config->num_usbs + 1));
> + usb = d_config->usbs + d_config->num_usbs;
> + libxl_device_usb_init(usb);
> +
Ditto.
Wei.
> + parse_usb_config(usb, buf);
> +
> + d_config->num_usbs++;
> + }
> + }
> +
> switch (xlu_cfg_get_list(config, "cpuid", &cpuids, 0, 1)) {
> case 0:
> {
> --
> 2.1.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-08-11 11:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 10:35 [PATCH V6 0/7] xen pvusb toolstack work Chunyan Liu
2015-08-10 10:35 ` [PATCH V6 1/7] libxl: export some functions for pvusb use Chunyan Liu
2015-08-11 11:26 ` Wei Liu
2015-08-10 10:35 ` [PATCH V6 2/7] libxl_read_file_contents: add new entry to read sysfs file Chunyan Liu
2015-08-11 11:26 ` Wei Liu
2015-08-12 2:37 ` Chun Yan Liu
2015-08-13 9:11 ` Wei Liu
2015-08-10 10:35 ` [PATCH V6 3/7] libxl: add pvusb API Chunyan Liu
2015-08-11 11:27 ` Wei Liu
2015-08-12 2:24 ` Chun Yan Liu
2015-08-13 9:09 ` Wei Liu
2015-08-14 1:49 ` Chun Yan Liu
2015-08-18 2:31 ` Chun Yan Liu
2015-08-31 6:10 ` Chun Yan Liu
2015-09-08 14:17 ` Ian Campbell
2015-09-08 16:52 ` George Dunlap
2015-09-09 7:38 ` Chun Yan Liu
2015-09-17 8:19 ` Chun Yan Liu
2015-09-17 9:54 ` George Dunlap
2015-09-29 17:19 ` Wei Liu
2015-09-17 8:20 ` Chun Yan Liu
2015-09-11 5:42 ` Chun Yan Liu
2015-09-11 13:26 ` Ian Campbell
2015-09-11 13:55 ` Juergen Gross
2015-09-11 14:09 ` Ian Campbell
2015-09-11 14:18 ` Juergen Gross
2015-09-11 14:41 ` Ian Campbell
2015-09-11 15:42 ` Ian Jackson
2015-09-14 3:48 ` Juergen Gross
2015-09-14 10:36 ` George Dunlap
2015-09-14 10:53 ` Juergen Gross
2015-09-14 11:12 ` Ian Jackson
2015-09-14 11:23 ` Juergen Gross
2015-09-14 14:03 ` George Dunlap
2015-09-17 8:24 ` Chun Yan Liu
2015-09-15 8:14 ` Chun Yan Liu
2015-08-10 10:35 ` [PATCH V6 4/7] libxl: add libxl_device_usb_assignable_list API Chunyan Liu
2015-08-10 10:35 ` [PATCH V6 5/7] xl: add pvusb commands Chunyan Liu
2015-08-10 10:35 ` [PATCH V6 6/7] xl: add usb-assignable-list command Chunyan Liu
2015-08-10 10:35 ` [PATCH V6 7/7] domcreate: support pvusb in configuration file Chunyan Liu
2015-08-11 11:27 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811112705.GG7460@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=caobosimon@gmail.com \
--cc=cyliu@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jfehlig@suse.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.