* [PATCH] ARM: imx: mach-imx6ul: Fix allmodconfig build
@ 2015-08-19 18:31 Fabio Estevam
2015-08-20 8:57 ` Shawn Guo
2015-08-21 16:37 ` Olof Johansson
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2015-08-19 18:31 UTC (permalink / raw
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
We should call phy_register_fixup_for_uid() only when CONFIG_PHYLIB
is built-in, otherwise we get the following link error when building
allmodconfig:
arch/arm/mach-imx/built-in.o: In function `imx6ul_init_machine':
:(.init.text+0xa714): undefined reference to `phy_register_fixup_for_uid'
This is the same approach done in mach-imx6q.c and mach-imx6sx.c.
Reported-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/mach-imx/mach-imx6ul.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mach-imx6ul.c b/arch/arm/mach-imx/mach-imx6ul.c
index db74da5..1b97fe1 100644
--- a/arch/arm/mach-imx/mach-imx6ul.c
+++ b/arch/arm/mach-imx/mach-imx6ul.c
@@ -45,7 +45,9 @@ static int ksz8081_phy_fixup(struct phy_device *dev)
static void __init imx6ul_enet_phy_init(void)
{
- phy_register_fixup_for_uid(PHY_ID_KSZ8081, 0xffffffff, ksz8081_phy_fixup);
+ if (IS_BUILTIN(CONFIG_PHYLIB))
+ phy_register_fixup_for_uid(PHY_ID_KSZ8081, 0xffffffff,
+ ksz8081_phy_fixup);
}
static inline void imx6ul_enet_init(void)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: imx: mach-imx6ul: Fix allmodconfig build
2015-08-19 18:31 [PATCH] ARM: imx: mach-imx6ul: Fix allmodconfig build Fabio Estevam
@ 2015-08-20 8:57 ` Shawn Guo
2015-08-21 16:37 ` Olof Johansson
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2015-08-20 8:57 UTC (permalink / raw
To: linux-arm-kernel
On Wed, Aug 19, 2015 at 03:31:30PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We should call phy_register_fixup_for_uid() only when CONFIG_PHYLIB
> is built-in, otherwise we get the following link error when building
> allmodconfig:
>
> arch/arm/mach-imx/built-in.o: In function `imx6ul_init_machine':
> :(.init.text+0xa714): undefined reference to `phy_register_fixup_for_uid'
>
> This is the same approach done in mach-imx6q.c and mach-imx6sx.c.
>
> Reported-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Thanks, Fabio.
Acked-by: Shawn Guo <shawnguo@kernel.org>
Olof,
I suppose that you will pick up the fix directly. Let me know if you
think differently. Thanks.
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: imx: mach-imx6ul: Fix allmodconfig build
2015-08-19 18:31 [PATCH] ARM: imx: mach-imx6ul: Fix allmodconfig build Fabio Estevam
2015-08-20 8:57 ` Shawn Guo
@ 2015-08-21 16:37 ` Olof Johansson
1 sibling, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2015-08-21 16:37 UTC (permalink / raw
To: linux-arm-kernel
On Wed, Aug 19, 2015 at 03:31:30PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We should call phy_register_fixup_for_uid() only when CONFIG_PHYLIB
> is built-in, otherwise we get the following link error when building
> allmodconfig:
>
> arch/arm/mach-imx/built-in.o: In function `imx6ul_init_machine':
> :(.init.text+0xa714): undefined reference to `phy_register_fixup_for_uid'
>
> This is the same approach done in mach-imx6q.c and mach-imx6sx.c.
>
> Reported-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Thanks, applied.
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-21 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 18:31 [PATCH] ARM: imx: mach-imx6ul: Fix allmodconfig build Fabio Estevam
2015-08-20 8:57 ` Shawn Guo
2015-08-21 16:37 ` Olof Johansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.