From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Sat, 29 Aug 2015 14:09:24 +0200 Subject: [U-Boot] [PATCH 2/2] mmc: dw_mmc: Make timeout error visible to u-boot console In-Reply-To: References: <1440769821-24005-1-git-send-email-l.majewski@samsung.com> <1440769821-24005-2-git-send-email-l.majewski@samsung.com> Message-ID: <20150829140924.5ca485e0@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 28 Aug 2015 17:21:51 -0600 Simon Glass wrote: > Hi Lukasz, > > On 28 August 2015 at 07:50, Lukasz Majewski > wrote: > > > > The timeout error for DW MMC transfer should be visible on the > > u-boot console to speed up the process of debugging. > > > > Signed-off-by: Lukasz Majewski > > Cc: Tom Rini > > Cc: Simon Glass > > --- > > drivers/mmc/dw_mmc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Can this be reported at the command line level instead? With my setup - dfu tests - I didn't receive any error/information about the MMC (SD Card to be precise) timeout. (I would expect MMC subsystem to return -ETIMEOUT and then this error would be propagated to dfu and stop execution of the dfu command). This didn't work and hence should be scrutinized. > It feels wrong > to be printing errors in a driver. If this information would be printed on the console I might have noticed it immediately and save some time for debugging. > Also, why does it return TIMEOUT > instead of -ETIMEOUT? Good question. > > Regards, > Simon Best regards, Lukasz Majewski -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 181 bytes Desc: OpenPGP digital signature URL: