From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754231AbbIJC53 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Sep 2015 22:57:29 -0400
Received: from mga11.intel.com ([192.55.52.93]:33828 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752441AbbIJC5Z (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Sep 2015 22:57:25 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,501,1437462000"; 
   d="scan'208";a="641932900"
Date: Thu, 10 Sep 2015 03:07:48 +0800
From: Yuyang Du <yuyang.du@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steve Muckle <steve.muckle@linaro.org>,
        Morten Rasmussen <Morten.Rasmussen@arm.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
        Juri Lelli <Juri.Lelli@arm.com>,
        "sgurrappadi@nvidia.com" <sgurrappadi@nvidia.com>,
        "pang.xunlei@zte.com.cn" <pang.xunlei@zte.com.cn>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] sched/fair: Get rid of scaling utilization by
 capacity_orig
Message-ID: <20150909190748.GA21833@intel.com>
References: <1439569394-11974-1-git-send-email-morten.rasmussen@arm.com>
 <1439569394-11974-6-git-send-email-morten.rasmussen@arm.com>
 <55E8DD00.2030706@linaro.org>
 <55EDAF43.30500@arm.com>
 <CAKfTPtBmgc=7JMRcTL9VYdHxb7qgXBDFc62rb-jnSVCePwJNsg@mail.gmail.com>
 <55EDDD5A.70904@arm.com>
 <CAKfTPtA0N-YTFMpN8-8ZbwakcsaY7=N4gnM5JivzCWsZnRRezQ@mail.gmail.com>
 <20150908122606.GH3644@twins.programming.kicks-ass.net>
 <20150908125205.GW18673@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150908125205.GW18673@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 08, 2015 at 02:52:05PM +0200, Peter Zijlstra wrote:
>  
> +#if (SCHED_LOAD_SHIFT - SCHED_LOAD_RESOLUTION) != 10 || SCHED_CAPACITY_SHIFT != 10
> +#error "load tracking assumes 2^10 as unit"
> +#endif
> +

Sorry for late response. I might already missed somthing.

But I got a bit lost here, with:

#define SCHED_LOAD_SHIFT        (10 + SCHED_LOAD_RESOLUTION)
#define SCHED_CAPACITY_SHIFT    10

the #if is certainly false.