From: Daniel Vetter <daniel@ffwll.ch>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 05/10] drm/i915: Remove legacy plane updates for cursor and sprite planes.
Date: Thu, 10 Sep 2015 17:38:31 +0200 [thread overview]
Message-ID: <20150910153831.GF2767@phenom.ffwll.local> (raw)
In-Reply-To: <1441894085-25662-6-git-send-email-maarten.lankhorst@linux.intel.com>
On Thu, Sep 10, 2015 at 04:08:00PM +0200, Maarten Lankhorst wrote:
> Unfortunately fbc still depends on legacy primary state, so
> it can't be killed off completely yet.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Wont it be enough that the helpers will update these legacy states for us?
And I didn't spot anything else really using them ...
What I did spot though is update_state_fb - the core should take care of
that now too for us since
commit 3cb43cc0b408c4672ba94fe28406a90a94b1edfe
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Tue Jul 7 08:43:03 2015 +0200
drm: Update plane->fb also for page_flip
Can you please have a testcase on top to remove this one too?
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 4 ----
> drivers/gpu/drm/i915/intel_sprite.c | 2 --
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index bad22cb828c0..87c5eba08454 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13662,10 +13662,6 @@ intel_commit_cursor_plane(struct drm_plane *plane,
> crtc = crtc ? crtc : plane->crtc;
> intel_crtc = to_intel_crtc(crtc);
>
> - plane->fb = state->base.fb;
> - crtc->cursor_x = state->base.crtc_x;
> - crtc->cursor_y = state->base.crtc_y;
> -
> if (intel_crtc->cursor_bo == obj)
> goto update;
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index ca7e26430e66..9553859ca151 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -927,8 +927,6 @@ intel_commit_sprite_plane(struct drm_plane *plane,
>
> crtc = crtc ? crtc : plane->crtc;
>
> - plane->fb = fb;
> -
> if (!crtc->state->active)
> return;
>
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-10 15:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 14:07 [PATCH 00/10] Nuke some legacy state Maarten Lankhorst
2015-09-10 14:07 ` [PATCH 01/10] drm/i915: Use atomic plane state in the primary plane update Maarten Lankhorst
2015-09-14 13:27 ` Ville Syrjälä
2015-09-14 13:40 ` Maarten Lankhorst
2015-09-14 13:54 ` Ville Syrjälä
2015-09-14 14:23 ` Daniel Vetter
2015-09-14 14:31 ` Ville Syrjälä
2015-09-10 14:07 ` [PATCH 02/10] drm/i915: Use the plane state in intel_crtc_info Maarten Lankhorst
2015-09-10 14:07 ` [PATCH 03/10] drm/i915: Use the atomic state in intel_update_primary_planes Maarten Lankhorst
2015-09-10 15:32 ` Daniel Vetter
2015-09-10 15:43 ` Ville Syrjälä
2015-09-10 16:31 ` Daniel Vetter
2015-09-10 16:34 ` Ville Syrjälä
2015-09-14 9:02 ` Daniel Vetter
2015-09-14 9:41 ` [fixup PATCH] drm/i915: Only commit active planes when updating planes during reset Maarten Lankhorst
2015-09-14 13:12 ` Daniel Vetter
2015-09-10 14:07 ` [PATCH 04/10] drm/i915: Use atomic state when changing cursor visibility Maarten Lankhorst
2015-09-10 15:46 ` Ville Syrjälä
2015-09-10 14:08 ` [PATCH 05/10] drm/i915: Remove legacy plane updates for cursor and sprite planes Maarten Lankhorst
2015-09-10 15:38 ` Daniel Vetter [this message]
2015-09-10 14:08 ` [PATCH 06/10] drm/i915: Update legacy primary state outside the commit hook Maarten Lankhorst
2015-09-10 15:41 ` Daniel Vetter
2015-09-14 9:52 ` Maarten Lankhorst
2015-09-14 13:13 ` Daniel Vetter
2015-09-14 13:16 ` Maarten Lankhorst
2015-09-14 14:26 ` Daniel Vetter
2015-09-23 14:08 ` Maarten Lankhorst
2015-09-10 14:08 ` [PATCH 07/10] drm/i915: Do not handle a null plane state Maarten Lankhorst
2015-09-10 14:08 ` [PATCH 08/10] drm/i915: Use crtc->state for duplication Maarten Lankhorst
2015-09-10 15:46 ` Daniel Vetter
2015-09-10 15:49 ` Daniel Vetter
2015-09-10 14:08 ` [PATCH 09/10] drm/i915: Kill off a user of update_state_fb Maarten Lankhorst
2015-09-10 15:50 ` Daniel Vetter
2015-09-14 9:56 ` Maarten Lankhorst
2015-09-10 14:08 ` [PATCH 10/10] drm/i915: Only run commit when crtc is active Maarten Lankhorst
2015-09-10 15:51 ` Daniel Vetter
2015-09-14 10:02 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910153831.GF2767@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.