Hi, On Sun, Sep 13, 2015 at 01:43:51PM +0200, Gerhard Bertelsmann wrote: > Signed-off-by: Gerhard Bertelsmann A commit log would be nice. > --- > .../devicetree/bindings/net/can/sunxi_can.txt | 40 + > 1 files changed, 49 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/sunxi_can.txt b/Documentation/devicetree/bindings/net/can/sunxi_can.txt > new file mode 100644 > index 0000000..5db9abc > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/can/sunxi_can.txt > @@ -0,0 +1,40 @@ > +Allwinner A10/A20 CAN controller Device Tree Bindings > +----------------------------------------------------- > + > +Required properties: > +- compatible: "allwinner,sunxican" The compatible should be made using the earliest SoC using this IP. In our case, that would be the A10. The format we use is sun4i-a10-, which would make it sun4i-a10-can in this case. > +- reg: physical base address and size of the Allwinner A10/A20 CAN register map. > +- interrupts: interrupt specifier for the sole interrupt. > +- clocks: phandle and clock specifier Which clock? > +- pinctrl-0: pin control group to be used for this controller. > +- pinctrl-names: must be "default". Those are generic standalone properties. There's no really need to mention them. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com