From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755013AbbINKHm (ORCPT ); Mon, 14 Sep 2015 06:07:42 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:37714 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbbINKHk (ORCPT ); Mon, 14 Sep 2015 06:07:40 -0400 Date: Mon, 14 Sep 2015 12:07:36 +0200 From: Ingo Molnar To: Dave Hansen Cc: mingo@redhat.com, x86@kernel.org, bp@alien8.de, fenghua.yu@intel.com, tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org, Linus Torvalds , Andy Lutomirski , Denys Vlasenko , Brian Gerst , Peter Zijlstra , Thomas Gleixner , Oleg Nesterov Subject: Re: [PATCH 00/15] [v4] x86, fpu: XSAVE cleanups and sanity checks Message-ID: <20150914100736.GA1328@gmail.com> References: <20150902233123.3A7E5FB0@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150902233123.3A7E5FB0@viggo.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dave Hansen wrote: > Changes in v4: > * Fix up a few compile errors/warnings > > Changes in v3: > * rework XSTATE_* macros using Ingo's suggested naming > * change state size printk to be in decimal > * add some more sanity-checking to detect and work around > an undersized 'xregs_state' > * remove "nr_" from some of the names used. > > Changes in v2: > * remove references to Processor Trace XSAVE state > (will defer to another patch set) > * Remove some cruft from last patch > * move last_good_offset fix in to the patch that > introduced it > > These patches make some updates to the x86 XSAVE code. > > They have been build and boot tested including on hardware > and/or simulators with AVX-512 and MPX. It boots in all > of the tested configurations without hitting any of the > new warnings in this code. I even added the Memory > Protecion Keys (the xfeature after MPX) patches on top of > this and everything works fine. > > There are basically 5 things going on here: > * removal of the LWP (lightweight profiling) code > * naming and type cleanups > * removal of xfeatures_nr variable > * addition of AVX-512 C structures > * new sanity checks of XSAVE buffer sizing Ok, very nice! I've applied your series to tip:x86/fpu and will push it out unless testing finds any problems. Thanks, Ingo