From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755302AbbINM0I (ORCPT ); Mon, 14 Sep 2015 08:26:08 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37724 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751858AbbINM0F (ORCPT ); Mon, 14 Sep 2015 08:26:05 -0400 Date: Mon, 14 Sep 2015 14:28:49 +0200 From: Daniel Vetter To: Masanari Iida Cc: daniel.vetter@intel.com, jani.nikula@linux.intel.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, corbet@lwn.net Subject: Re: [PATCH] drm/i915: Fix warnings while make xmldocs caused by intel_lrc.c Message-ID: <20150914122849.GC3383@phenom.ffwll.local> Mail-Followup-To: Masanari Iida , daniel.vetter@intel.com, jani.nikula@linux.intel.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, corbet@lwn.net References: <1442146111-29596-1-git-send-email-standby24x7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442146111-29596-1-git-send-email-standby24x7@gmail.com> X-Operating-System: Linux phenom 4.1.0-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2015 at 09:08:31PM +0900, Masanari Iida wrote: > This patch fix following warnings while "make xmldocs". > .//drivers/gpu/drm/i915/intel_lrc.c:780: warning: No description > found for parameter 'req' > .//drivers/gpu/drm/i915/intel_lrc.c:780: warning: Excess function > parameter 'request' description in 'intel_logical_ring_begin' > .//drivers/gpu/drm/i915/intel_lrc.c:780: warning: Excess function > parameter 'ctx' description in 'intel_logical_ring_begin' > > Signed-off-by: Masanari Iida Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_lrc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c > index 72e0edd..963992a 100644 > --- a/drivers/gpu/drm/i915/intel_lrc.c > +++ b/drivers/gpu/drm/i915/intel_lrc.c > @@ -765,8 +765,7 @@ static int logical_ring_prepare(struct drm_i915_gem_request *req, int bytes) > /** > * intel_logical_ring_begin() - prepare the logical ringbuffer to accept some commands > * > - * @request: The request to start some new work for > - * @ctx: Logical ring context whose ringbuffer is being prepared. > + * @req: The request to start some new work for > * @num_dwords: number of DWORDs that we plan to write to the ringbuffer. > * > * The ringbuffer might not be ready to accept the commands right away (maybe it needs to > -- > 2.6.0.rc0.24.gec371ff > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix warnings while make xmldocs caused by intel_lrc.c Date: Mon, 14 Sep 2015 14:28:49 +0200 Message-ID: <20150914122849.GC3383@phenom.ffwll.local> References: <1442146111-29596-1-git-send-email-standby24x7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AE62720D1 for ; Mon, 14 Sep 2015 05:26:06 -0700 (PDT) Received: by wicge5 with SMTP id ge5so140366702wic.0 for ; Mon, 14 Sep 2015 05:26:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1442146111-29596-1-git-send-email-standby24x7@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Masanari Iida Cc: corbet@lwn.net, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBTZXAgMTMsIDIwMTUgYXQgMDk6MDg6MzFQTSArMDkwMCwgTWFzYW5hcmkgSWlkYSB3 cm90ZToKPiBUaGlzIHBhdGNoIGZpeCBmb2xsb3dpbmcgd2FybmluZ3Mgd2hpbGUgIm1ha2UgeG1s ZG9jcyIuCj4gLi8vZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmM6NzgwOiB3YXJuaW5n OiBObyBkZXNjcmlwdGlvbgo+IGZvdW5kIGZvciBwYXJhbWV0ZXIgJ3JlcScKPiAuLy9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYzo3ODA6IHdhcm5pbmc6IEV4Y2VzcyBmdW5jdGlvbgo+ ICBwYXJhbWV0ZXIgJ3JlcXVlc3QnIGRlc2NyaXB0aW9uIGluICdpbnRlbF9sb2dpY2FsX3Jpbmdf YmVnaW4nCj4gLi8vZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmM6NzgwOiB3YXJuaW5n OiBFeGNlc3MgZnVuY3Rpb24KPiAgcGFyYW1ldGVyICdjdHgnIGRlc2NyaXB0aW9uIGluICdpbnRl bF9sb2dpY2FsX3JpbmdfYmVnaW4nCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFzYW5hcmkgSWlkYSA8 c3RhbmRieTI0eDdAZ21haWwuY29tPgoKUXVldWVkIGZvciAtbmV4dCwgdGhhbmtzIGZvciB0aGUg cGF0Y2guCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5j IHwgMyArLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggNzJlMGVkZC4uOTYzOTkyYSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTc2NSw4ICs3NjUsNyBAQCBzdGF0 aWMgaW50IGxvZ2ljYWxfcmluZ19wcmVwYXJlKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAq cmVxLCBpbnQgYnl0ZXMpCj4gIC8qKgo+ICAgKiBpbnRlbF9sb2dpY2FsX3JpbmdfYmVnaW4oKSAt IHByZXBhcmUgdGhlIGxvZ2ljYWwgcmluZ2J1ZmZlciB0byBhY2NlcHQgc29tZSBjb21tYW5kcwo+ ICAgKgo+IC0gKiBAcmVxdWVzdDogVGhlIHJlcXVlc3QgdG8gc3RhcnQgc29tZSBuZXcgd29yayBm b3IKPiAtICogQGN0eDogTG9naWNhbCByaW5nIGNvbnRleHQgd2hvc2UgcmluZ2J1ZmZlciBpcyBi ZWluZyBwcmVwYXJlZC4KPiArICogQHJlcTogVGhlIHJlcXVlc3QgdG8gc3RhcnQgc29tZSBuZXcg d29yayBmb3IKPiAgICogQG51bV9kd29yZHM6IG51bWJlciBvZiBEV09SRHMgdGhhdCB3ZSBwbGFu IHRvIHdyaXRlIHRvIHRoZSByaW5nYnVmZmVyLgo+ICAgKgo+ICAgKiBUaGUgcmluZ2J1ZmZlciBt aWdodCBub3QgYmUgcmVhZHkgdG8gYWNjZXB0IHRoZSBjb21tYW5kcyByaWdodCBhd2F5IChtYXli ZSBpdCBuZWVkcyB0bwo+IC0tIAo+IDIuNi4wLnJjMC4yNC5nZWMzNzFmZgo+IAo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxp bmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK