From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Yetunde Adebisi <yetundex.adebisi@intel.com>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Backlight Control over AUX feature
Date: Mon, 14 Sep 2015 15:15:51 +0200 [thread overview]
Message-ID: <20150914131551.GH3383@phenom.ffwll.local> (raw)
In-Reply-To: <87wpvtjp6t.fsf@intel.com>
On Mon, Sep 14, 2015 at 01:00:26PM +0300, Jani Nikula wrote:
> On Thu, 10 Sep 2015, Yetunde Adebisi <yetundex.adebisi@intel.com> wrote:
> > This patch adds support for Backlight Control over the AUX channel for
> > DP and eDP connectors. It allows the backlight of DP and eDP connected
> > displays to be controlled from software using sysfs interface.
>
> Which spec says there's DPCD backlight control support on non-embedded
> Display Port? AFAICT it's just eDP.
>
> > The code first checks if the DP/eDP display has the capability for
> > backlight control by reading Display Control DPCD registers as defined
> > by the eDP v1.3 VESA specs.
> > It then registers a /sys/backlight device if backlight control is
> > supported.
> >
> > It provides functions to
> > - Register a sysfs backlight interface if the eDP/DP connnector is
> > capable of aux backlight control
> > - Read the current backlight level from DPCD register 0x722
> > - Change the backlight level
> > - Disable/Enable the backlight by writing to DPCD register 0x720
>
> IMO the design should be to move dev_priv->display backlight hooks to be
> connector specific, in intel_panel, and it would be transparent whether
> backlight control is AUX based, GPU PWM based, PMIC PWM based, or DSI
> command mode based. I've given the exact same feedback about the recent
> DSI command mode backlight code.
Registering piles of backlight controllers and letting userspace pick it
is how it works currently. Ugly, but well that's how it is. Fixing that up
would be a bit of work ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-14 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 14:11 [PATCH] drm/i915: Backlight Control over AUX feature Yetunde Adebisi
2015-09-10 15:20 ` Daniel Vetter
2015-09-14 16:29 ` Adebisi, YetundeX
2015-09-14 17:18 ` Daniel Vetter
2015-09-14 10:00 ` Jani Nikula
2015-09-14 13:15 ` Daniel Vetter [this message]
2015-09-14 14:40 ` Adebisi, YetundeX
2015-09-15 7:26 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914131551.GH3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=yetundex.adebisi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.