From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZbVoc-0001MB-Pf
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 11:37:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZbVob-0007sS-Sr
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 11:37:10 -0400
Date: Mon, 14 Sep 2015 17:37:00 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150914153700.GE3550@noname.str.redhat.com>
References: <1441878905-5272-1-git-send-email-wency@cn.fujitsu.com>
	<1441878905-5272-5-git-send-email-wency@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1441878905-5272-5-git-send-email-wency@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to
	add/remove a child
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Alberto Garcia <berto@igalia.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu block <qemu-block@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu devel <qemu-devel@nongnu.org>, Gonglei <arei.gonglei@huawei.com>, Stefan Hajnoczi <stefanha@redhat.com>, Yang Hongyang <yanghy@cn.fujitsu.com>

Am 10.09.2015 um 11:55 hat Wen Congyang geschrieben:
> +##
> +# @x-child-add
> +#
> +# Add a new child to the parent BDS. Currently only the Quorum driver
> +# implements this feature. This is useful to fix a broken quorum child.
> +#
> +# @parent: graph node name or id which the child will be added to.
> +#
> +# @child: graph node name that will be added.
> +#
> +# Note: this command is experimental, and not a stable API.
> +#
> +# Since: 2.5
> +##
> +{ 'command': 'x-child-add',
> +  'data' : { 'parent': 'str', 'child': 'str' } }

This is probably not future-proof and only made for the special case of
quorum. Specifically, one thing I'm missing is some way to specfiy what
kind of child the new node is when a node can take different types of
children (e.g. bs->file and bs->backing_hd).

Kevin