On Sun, Sep 13, 2015 at 03:21:35PM +0200, Jonas Gorski wrote: > Replace all trivial request/free callbacks that do nothing but call into > pinctrl code with the generic versions. > > Signed-off-by: Jonas Gorski > --- > drivers/gpio/gpio-tz1090-pdc.c | 14 ++------------ For the tz1090-pdc bit: Acked-by: James Hogan Cheers James > diff --git a/drivers/gpio/gpio-tz1090-pdc.c b/drivers/gpio/gpio-tz1090-pdc.c > index ede7e40..3623d00 100644 > --- a/drivers/gpio/gpio-tz1090-pdc.c > +++ b/drivers/gpio/gpio-tz1090-pdc.c > @@ -137,16 +137,6 @@ static void tz1090_pdc_gpio_set(struct gpio_chip *chip, unsigned int offset, > __global_unlock2(lstat); > } > > -static int tz1090_pdc_gpio_request(struct gpio_chip *chip, unsigned int offset) > -{ > - return pinctrl_request_gpio(chip->base + offset); > -} > - > -static void tz1090_pdc_gpio_free(struct gpio_chip *chip, unsigned int offset) > -{ > - pinctrl_free_gpio(chip->base + offset); > -} > - > static int tz1090_pdc_gpio_to_irq(struct gpio_chip *chip, unsigned int offset) > { > struct tz1090_pdc_gpio *priv = to_pdc(chip); > @@ -203,8 +193,8 @@ static int tz1090_pdc_gpio_probe(struct platform_device *pdev) > priv->chip.direction_output = tz1090_pdc_gpio_direction_output; > priv->chip.get = tz1090_pdc_gpio_get; > priv->chip.set = tz1090_pdc_gpio_set; > - priv->chip.free = tz1090_pdc_gpio_free; > - priv->chip.request = tz1090_pdc_gpio_request; > + priv->chip.free = gpiochip_generic_free; > + priv->chip.request = gpiochip_generic_request; > priv->chip.to_irq = tz1090_pdc_gpio_to_irq; > priv->chip.of_node = np; >